From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michal Wajdeczko" Subject: Re: [PATCH v3 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes Date: Sat, 14 Apr 2018 04:15:53 +0200 Message-ID: References: <1523320940-32742-1-git-send-email-yaodong.li@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F0856E058 for ; Sat, 14 Apr 2018 02:15:59 +0000 (UTC) In-Reply-To: <1523320940-32742-1-git-send-email-yaodong.li@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Jackie Li List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxMCBBcHIgMjAxOCAwMjo0MjoxNyArMDIwMCwgSmFja2llIExpIDx5YW9kb25nLmxp QGludGVsLmNvbT4gd3JvdGU6Cgo+IEFmdGVyIGVuYWJsZWQgdGhlIFdPUENNIHdyaXRlLW9uY2Ug cmVnaXN0ZXJzIGxvY2tpbmcgc3RhdHVzIGNoZWNraW5nLAo+IHJlbG9hZGluZyBvZiB0aGUgaTkx NSBtb2R1bGUgd2lsbCBmYWlsIHdpdGggbW9kcGFyYW0gZW5hYmxlX2d1YyBzZXQgdG8gMwo+IChl bmFibGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgbG9hZGluZykgaWYgdGhlIG1vZHVsZSB3YXMgb3Jp Z2luYWxseSBsb2FkZWQKPiB3aXRoIGVuYWJsZV9ndWMgc2V0IHRvIDEgKG9ubHkgZW5hYmxlIEd1 QyBmaXJtd2FyZSBsb2FkaW5nKS4KCklzIHRoaXMgZnJlcXVlbnQgYW5kIHJlcXVpcmVkIHNjZW5h cmlvID8gb3IganVzdCBmb3IgZGVidWcvZGV2ZWxvcG1lbnQgPwoKPiBUaGlzIGlzCj4gYmVjYXVz ZSBXT1BDTSByZWdpc3RlcnMgd2VyZSB1cGRhdGVkIGFuZCBsb2NrZWQgd2l0aG91dCBjb25zaWRl cmluZyB0aGUgIAo+IEh1Qwo+IEZXIHNpemUuIFNpbmNlIHdlIG5lZWQgYm90aCBHdUMgYW5kIEh1 QyBGVyBzaXplcyB0byBkZXRlcm1pbmUgdGhlIGZpbmFsCj4gbGF5b3V0IG9mIFdPUENNLCB3ZSBz aG91bGQgYWx3YXlzIGNhbGN1bGF0ZSB0aGUgV09QQ00gbGF5b3V0IGJhc2VkIG9uIHRoZQo+IGFj dHVhbCBzaXplcyBvZiB0aGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgYXZhaWxhYmxlIGZvciBhIHNw ZWNpZmljICAKPiBwbGF0Zm9ybQo+IGlmIHdlIG5lZWQgY29udGludWUgdG8gc3VwcG9ydCBlbmFi bGUvZGlzYWJsZSBIdUMgRlcgbG9hZGluZyBkeW5hbWljYWxseQo+IHdpdGggZW5hYmxlX2d1YyBt b2RwYXJhbS4KPgo+IFRoaXMgcGF0Y2ggc3BsaXRzIHVDIGZpcm13YXJlIGZldGNoaW5nIGludG8g dHdvIHN0YWdlcy4gRmlyc3Qgc3RhZ2UgaXMgdG8KPiBmZXRjaCB0aGUgZmlybXdhcmUgaW1hZ2Ug YW5kIHZlcmlmeSB0aGUgZmlybXdhcmUgaGVhZGVyLiB1QyBmaXJtd2FyZSB3aWxsCj4gYmUgbWFy a2VkIGFzIHZlcmlmaWVkIGFuZCB0aGlzIHdpbGwgbWFrZSBGVyBpbmZvIGF2YWlsYWJsZSBmb3Ig Zm9sbG93aW5nCj4gV09QQ00gbGF5b3V0IGNhbGN1bGF0aW9uLiBUaGUgc2Vjb25kIHN0YWdlIGlz IHRvIGNyZWF0ZSBhIEdFTSBvYmplY3QgYW5kCj4gY29weSB0aGUgRlcgZGF0YSBpbnRvIHRoZSBj cmVhdGVkIEdFTSBvYmplY3Qgd2hpY2ggd2lsbCBvbmx5IGJlIGF2YWlsYWJsZQo+IHdoZW4gR3VD L0h1QyBsb2FkaW5nIGlzIGVuYWJsZWQgYnkgZW5hYmxlX2d1YyBtb2RwYXJhbS4gVGhpcyB3aWxs ICAKPiBndWFyYW50ZWUKPiB0aGF0IHRoZSBXT1BDTSBsYXlvdXQgd2lsbCBiZSBhbHdheXMgYmUg Y2FsY3VsYXRlZCBjb3JyZWN0bHkgd2l0aG91dCAgCj4gbWFraW5nCj4gYW55IGFzc3VtcHRpb25z IHRvIHRoZSBHdUMgYW5kIEh1QyBmaXJtd2FyZSBzaXplcy4KCllvdSBhcmUgYWxzbyBhc3N1bWlu ZyB0aGF0IG9uIHJlbG9hZCBleGFjdGx5IHRoZSBzYW1lIEd1Qy9IdUMgZmlybXdhcmVzCndpbGwg YmVlIHVzZWQgYXMgaW4gaW5pdGlhbCBydW4uIFRoaXMgd2lsbCBtYWtlIHRoaXMgdXNlbGVzcyBm b3IgZGVidWcvCmRldmVsb3BtZW50IHNjZW5hcmlvcywgd2hlcmUgY3VzdG9tIGZ3IGFyZSBsaWtl bHkgdG8gYmUgc3BlY2lmaWVkLgoKSWYgd2Ugd2FudCB0byBzdXBwb3J0IGVuYWJsZV9ndWM9MS0+ My0+MSBzY2VuYXJpb3MgZm9yIGRlYnVnL2RldiB0aGVuCm1heWJlIG1vcmUgZmxleGlibGUgd2ls bCBiZSBvdGhlciBhcHByb2FjaCB0aGF0IG1ha2VzIGFsbG9jYXRpb25zIGZyb20KdGhlIG90aGVy IGVuZCBhcyBwcm9wb3NlZCBpbiBbMV0KClsxXSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3Rv cC5vcmcvcGF0Y2gvMjEyNDcxLwoKPgo+IHYzOgo+ICAtIFJlYmFzZQo+Cj4gU2lnbmVkLW9mZi1i eTogSmFja2llIExpIDx5YW9kb25nLmxpQGludGVsLmNvbT4KPiBDYzogTWljaGFsIFdhamRlY3pr byA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxz YWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXaW5pYXJza2kgPG1pY2hhbC53 aW5pYXJza2lAaW50ZWwuY29tPgo+IENjOiBKb2huIFNwb3Rzd29vZCA8am9obi5hLnNwb3Rzd29v ZEBpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICB8 IDE0ICsrKystLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMg fCAzMSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjX2Z3LmggfCAgNyArKysrKy0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjkgaW5z ZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdWMuYyAgCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5j Cj4gaW5kZXggMWNmZmFmNy4uNzNiOGY2YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ IEBAIC0xNzIsMTEgKzE3Miw4IEBAIHZvaWQgaW50ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAgCj4gKmk5MTUpCj4gCXNhbml0aXplX29wdGlvbnNfZWFybHkoaTkxNSk7 Cj4gLQlpZiAoVVNFU19HVUMoaTkxNSkpCj4gLQkJaW50ZWxfdWNfZndfZmV0Y2goaTkxNSwgJmd1 Yy0+ZncpOwo+IC0KPiAtCWlmIChVU0VTX0hVQyhpOTE1KSkKPiAtCQlpbnRlbF91Y19md19mZXRj aChpOTE1LCAmaHVjLT5mdyk7Cj4gKwlpbnRlbF91Y19md19mZXRjaChpOTE1LCAmZ3VjLT5mdywg VVNFU19HVUMoaTkxNSkpOwo+ICsJaW50ZWxfdWNfZndfZmV0Y2goaTkxNSwgJmh1Yy0+ZncsIFVT RVNfSFVDKGk5MTUpKTsKCkhtbSwgc2lkZSBlZmZlY3Qgb2YgdGhvc2UgdW5jb25kaXRpb25hbCBm ZXRjaGVzIG1pZ2h0IGJlIHVud2FudGVkIHdhcm5pbmdzCmFib3V0IG1pc3NpbmcgZmlybXdhcmVz IChvbiBjb25maWdzIHdpdGggZGlzYWJsZWQgZ3VjKSBhcyB3ZWxsIGFzIGV4dGVuZGVkCmRyaXZl ciBsb2FkIHRpbWUuCgpEbyB3ZSByZWFsbHkgbmVlZCB0byBzdXBwb3J0IHRoaXMgY29ybmVyIGNh c2UgZW5hYmxlX2d1Yz0xLT4zIGF0IGFsbCBjb3N0cz8KCi9taWNoYWwKCj4gIH0KPiB2b2lkIGlu dGVsX3VjX2NsZWFudXBfZWFybHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gQEAg LTE4NCwxMSArMTgxLDggQEAgdm9pZCBpbnRlbF91Y19jbGVhbnVwX2Vhcmx5KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICAKPiAqaTkxNSkKPiAgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZpOTE1 LT5ndWM7Cj4gIAlzdHJ1Y3QgaW50ZWxfaHVjICpodWMgPSAmaTkxNS0+aHVjOwo+IC0JaWYgKFVT RVNfSFVDKGk5MTUpKQo+IC0JCWludGVsX3VjX2Z3X2ZpbmkoJmh1Yy0+ZncpOwo+IC0KPiAtCWlm IChVU0VTX0dVQyhpOTE1KSkKPiAtCQlpbnRlbF91Y19md19maW5pKCZndWMtPmZ3KTsKPiArCWlu dGVsX3VjX2Z3X2ZpbmkoJmh1Yy0+ZncpOwo+ICsJaW50ZWxfdWNfZndfZmluaSgmZ3VjLT5mdyk7 Cj4gCWd1Y19mcmVlX2xvYWRfZXJyX2xvZyhndWMpOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMgIAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdWNfZncuYwo+IGluZGV4IDZlOGUwYjUuLmE5Y2I5MDAgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjX2Z3LmMKPiBAQCAtMzMsMTEgKzMzLDEzIEBACj4gICAqCj4gICAqIEBkZXZf cHJpdjogZGV2aWNlIHByaXZhdGUKPiAgICogQHVjX2Z3OiB1QyBmaXJtd2FyZQo+ICsgKiBAY29w eV90b19vYmo6IHdoZXRoZXIgZmV0Y2ggdUMgZmlybXdhcmUgaW50byBHRU0gb2JqZWN0IG9yIG5v dAoKcy9jb3B5X3RvX29iai9mZXRjaAoKPiAgICoKPiAtICogRmV0Y2ggdUMgZmlybXdhcmUgaW50 byBHRU0gb2JqLgo+ICsgKiBGZXRjaCBhbmQgdmVyaWZ5IHVDIGZpcm13YXJlIGFuZCBjb3B5IGZp cm13YXJlIGRhdGEgaW50byBHRU0gb2JqZWN0ICAKPiBpZgo+ICsgKiBAY29weV90b19vYmogaXMg dHJ1ZS4KPiAgICovCj4gIHZvaWQgaW50ZWxfdWNfZndfZmV0Y2goc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+IC0JCSAgICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3KQo+ ICsJCSAgICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3LCBib29sIGNvcHlfdG9fb2JqKQo+ ICB7Cj4gIAlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGRldl9wcml2LT5kcm0ucGRldjsKPiAgCXN0 cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gQEAgLTE1NCwxNyArMTU2LDI0IEBAIHZv aWQgaW50ZWxfdWNfZndfZmV0Y2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgIAo+ICpkZXZfcHJp diwKPiAgCQlnb3RvIGZhaWw7Cj4gIAl9Cj4gLQlvYmogPSBpOTE1X2dlbV9vYmplY3RfY3JlYXRl X2Zyb21fZGF0YShkZXZfcHJpdiwgZnctPmRhdGEsIGZ3LT5zaXplKTsKPiAtCWlmIChJU19FUlIo b2JqKSkgewo+IC0JCWVyciA9IFBUUl9FUlIob2JqKTsKPiAtCQlEUk1fREVCVUdfRFJJVkVSKCIl cyBmdyBvYmplY3RfY3JlYXRlIGVycj0lZFxuIiwKPiAtCQkJCSBpbnRlbF91Y19md190eXBlX3Jl cHIodWNfZnctPnR5cGUpLCBlcnIpOwo+IC0JCWdvdG8gZmFpbDsKPiArCXVjX2Z3LT5zaXplID0g ZnctPnNpemU7Cj4gKwl1Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfVkVS SUZJRUQ7Cj4gKwo+ICsJaWYgKGNvcHlfdG9fb2JqKSB7Cj4gKwkJb2JqID0gaTkxNV9nZW1fb2Jq ZWN0X2NyZWF0ZV9mcm9tX2RhdGEoZGV2X3ByaXYsIGZ3LT5kYXRhLAo+ICsJCQkJCQkgICAgICAg ZnctPnNpemUpOwo+ICsJCWlmIChJU19FUlIob2JqKSkgewo+ICsJCQllcnIgPSBQVFJfRVJSKG9i aik7Cj4gKwkJCURSTV9ERUJVR19EUklWRVIoIiVzIGZ3IG9iamVjdF9jcmVhdGUgZXJyPSVkXG4i LAo+ICsJCQkJCSBpbnRlbF91Y19md190eXBlX3JlcHIodWNfZnctPnR5cGUpLAo+ICsJCQkJCSBl cnIpOwo+ICsJCQlnb3RvIGZhaWw7Cj4gKwkJfQo+ICsKPiArCQl1Y19mdy0+b2JqID0gb2JqOwo+ ICsJCXVjX2Z3LT5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJNV0FSRV9TVUNDRVNTOwo+ICAJ fQo+IC0JdWNfZnctPm9iaiA9IG9iajsKPiAtCXVjX2Z3LT5zaXplID0gZnctPnNpemU7Cj4gLQl1 Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUzsKPiAgCURSTV9E RUJVR19EUklWRVIoIiVzIGZ3IGZldGNoICVzXG4iLAo+ICAJCQkgaW50ZWxfdWNfZndfdHlwZV9y ZXByKHVjX2Z3LT50eXBlKSwKPiAgCQkJIGludGVsX3VjX2Z3X3N0YXR1c19yZXByKHVjX2Z3LT5m ZXRjaF9zdGF0dXMpKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dWNfZncuaCAgCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5oCj4gaW5kZXgg ZGMzM2IxMi4uNGU3ZWNjOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91Y19mdy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaAo+IEBA IC0zNiw2ICszNiw3IEBAIGVudW0gaW50ZWxfdWNfZndfc3RhdHVzIHsKPiAgCUlOVEVMX1VDX0ZJ Uk1XQVJFX0ZBSUwgPSAtMSwKPiAgCUlOVEVMX1VDX0ZJUk1XQVJFX05PTkUgPSAwLAo+ICAJSU5U RUxfVUNfRklSTVdBUkVfUEVORElORywKPiArCUlOVEVMX1VDX0ZJUk1XQVJFX1ZFUklGSUVELAo+ ICAJSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUwo+ICB9Owo+IEBAIC04NCw2ICs4NSw4IEBAIGNv bnN0IGNoYXIgKmludGVsX3VjX2Z3X3N0YXR1c19yZXByKGVudW0gIAo+IGludGVsX3VjX2Z3X3N0 YXR1cyBzdGF0dXMpCj4gIAkJcmV0dXJuICJOT05FIjsKPiAgCWNhc2UgSU5URUxfVUNfRklSTVdB UkVfUEVORElORzoKPiAgCQlyZXR1cm4gIlBFTkRJTkciOwo+ICsJY2FzZSBJTlRFTF9VQ19GSVJN V0FSRV9WRVJJRklFRDoKPiArCQlyZXR1cm4gIlZFUklGSUVEIjsKPiAgCWNhc2UgSU5URUxfVUNf RklSTVdBUkVfU1VDQ0VTUzoKPiAgCQlyZXR1cm4gIlNVQ0NFU1MiOwo+ICAJfQo+IEBAIC0xMzEs MTQgKzEzNCwxNCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfdWNfZndfc2FuaXRpemUoc3Ry dWN0ICAKPiBpbnRlbF91Y19mdyAqdWNfZncpCj4gICAqLwo+ICBzdGF0aWMgaW5saW5lIHUzMiBp bnRlbF91Y19md19nZXRfdXBsb2FkX3NpemUoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdykKPiAg ewo+IC0JaWYgKHVjX2Z3LT5mZXRjaF9zdGF0dXMgIT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VT UykKPiArCWlmICh1Y19mdy0+ZmV0Y2hfc3RhdHVzIDwgSU5URUxfVUNfRklSTVdBUkVfVkVSSUZJ RUQpCj4gIAkJcmV0dXJuIDA7Cj4gCXJldHVybiB1Y19mdy0+aGVhZGVyX3NpemUgKyB1Y19mdy0+ dWNvZGVfc2l6ZTsKPiAgfQo+IHZvaWQgaW50ZWxfdWNfZndfZmV0Y2goc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCSAgICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3 KTsKPiArCQkgICAgICAgc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywgYm9vbCBjb3B5X3RvX29i aik7Cj4gIGludCBpbnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywK PiAgCQkgICAgICAgaW50ICgqeGZlcikoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywKPiAgCQkJ CSAgIHN0cnVjdCBpOTE1X3ZtYSAqdm1hKSk7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=