All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Oliva <oliva@gnu.org>
To: Gregory Farnum <greg@inktank.com>
Cc: "Yan, Zheng" <ukernel@gmail.com>,
	ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] enable mds rejoin with active inodes' old parent xattrs
Date: Sat, 24 Aug 2013 07:38:17 -0300	[thread overview]
Message-ID: <ory57ridba.fsf@livre.home> (raw)
In-Reply-To: <CAPYLRzjHPbRe-AKnzqb-M+jO78u9vMYdru+8kLGWmVEPNanfqA@mail.gmail.com> (Gregory Farnum's message of "Fri, 23 Aug 2013 13:11:14 -0700")

On Aug 23, 2013, Gregory Farnum <greg@inktank.com> wrote:

> On Fri, Aug 23, 2013 at 4:00 AM, Alexandre Oliva <oliva@gnu.org> wrote:
>> On Aug 22, 2013, "Yan, Zheng" <ukernel@gmail.com> wrote:
>> 
>>> This is not bug. Only the tail entry of the path encoded in the parent xattrs
>>> need to be updated. (the entry for inode's parent directory)
>> 
>> Why store the others, if they're not usable, then?  IMHO it just
>> introduces a risk of their being accidentally misused.

> We want to write a correct path whenever we touch the file, but we
> don't want to have to go out to each file's object in order to
> complete a directory rename. So for a given file object we consider
> only the immediate parent to be authoritative, but keep around the
> full path for disaster recovery.

Ok, so all this extra info is for disaster recovery only.  I guess that
makes some sense to me, as long as that's clear to everone who might
want to tap on that info.

> If we are touching the file's ancestor xattr and not updating the
> whole thing, that would be a bug, but I don't think that's what you're
> describing?

It was not, indeed.  Thanks for the clarification.

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

      reply	other threads:[~2013-08-24 10:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  6:40 [PATCH] enable mds rejoin with active inodes' old parent xattrs Alexandre Oliva
2013-08-22  8:27 ` Yan, Zheng
2013-08-22 15:16   ` Sage Weil
2013-08-23 11:00   ` Alexandre Oliva
2013-08-23 20:11     ` Gregory Farnum
2013-08-24 10:38       ` Alexandre Oliva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ory57ridba.fsf@livre.home \
    --to=oliva@gnu.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=greg@inktank.com \
    --cc=ukernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.