All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: Doc: Add warning and note on btrfs-convert.
Date: Fri, 3 Apr 2015 04:37:38 +0000 (UTC)	[thread overview]
Message-ID: <pan$47a87$b7d50fef$d2b62f95$e9e71c40@cox.net> (raw)
In-Reply-To: 20150402151931.GK6821@twin.jikos.cz

David Sterba posted on Thu, 02 Apr 2015 17:19:31 +0200 as excerpted:

> On Thu, Mar 26, 2015 at 10:19:24AM +0800, Qu Wenruo wrote:
>> WARNING: To ensure *btrfs-convert* be able to rollback btrfs, one
>> should never execute *btrfs filesystem defragment* or *btrfs balance*
>> command on the converted btrfs.

> I don't see now why defrag is harmful to rollback. The defragmented data
> are written to the "ext free space", ie. where all new modifications get
> written. The old data are pinned by the ext2_saved subvolume and can be
> restored. Or not?

Is defrag ever going to be snapshot-aware-enabled again?  If not, then I 
don't see that (snapshot-unaware) defrag can affect ext2_saved either.  
But with snapshot-aware-defrag, AFAIK defrag would affect ext2_saved, 
unless of course it was special-cased...

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


      parent reply	other threads:[~2015-04-03  4:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  2:19 [PATCH v2] btrfs-progs: Doc: Add warning and note on btrfs-convert Qu Wenruo
2015-04-02 15:19 ` David Sterba
2015-04-03  0:37   ` Qu Wenruo
2015-04-03  4:37   ` Duncan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$47a87$b7d50fef$d2b62f95$e9e71c40@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.