From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAE7C433E2 for ; Sun, 13 Sep 2020 11:04:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A176820829 for ; Sun, 13 Sep 2020 11:04:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="bxX3e03M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725969AbgIMLEC (ORCPT ); Sun, 13 Sep 2020 07:04:02 -0400 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:17819 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgIMLDu (ORCPT ); Sun, 13 Sep 2020 07:03:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1599995031; x=1631531031; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=JPqkWOIRFmR6XWe+wPkArUVRUL+EGbiVYPSdNAyk2+4=; b=bxX3e03MEz98re+fD422ihNCdOhiMzh5W9GrXf6DzVjnthgJAlo/Qzew MU4O4IcZTsYZEWPTE8YqEXZ8MVXbiYJTzs5+QScSBQtg88VGOsngZwrm4 5CNsOsu9IyJyGRgTcg5evqCGLjwC4B4mODFaM0vZBCJapVfE01Z/2HADt o=; X-IronPort-AV: E=Sophos;i="5.76,421,1592870400"; d="scan'208";a="53414756" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-c7131dcf.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 13 Sep 2020 11:03:49 +0000 Received: from EX13D28EUC001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2b-c7131dcf.us-west-2.amazon.com (Postfix) with ESMTPS id 2F54AA23F4; Sun, 13 Sep 2020 11:03:48 +0000 (UTC) Received: from u68c7b5b1d2d758.ant.amazon.com.amazon.com (10.43.160.183) by EX13D28EUC001.ant.amazon.com (10.43.164.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 13 Sep 2020 11:03:39 +0000 References: <20200913082056.3610-6-shayagr@amazon.com> User-agent: mu4e 1.4.12; emacs 26.3 From: Shay Agroskin To: , CC: Shay Agroskin , , , , , , , , , , , , , , Subject: Re: [PATCH V1 net-next 5/8] net: ena: Remove redundant print of placement policy In-Reply-To: <20200913082056.3610-6-shayagr@amazon.com> Date: Sun, 13 Sep 2020 14:03:24 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Originating-IP: [10.43.160.183] X-ClientProxiedBy: EX13D50UWA001.ant.amazon.com (10.43.163.46) To EX13D28EUC001.ant.amazon.com (10.43.164.4) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Shay Agroskin writes: > The placement policy is printed in the process of queue creation > in > ena_up(). No need to print it in ena_probe(). > > Signed-off-by: Arthur Kiyanovski > Signed-off-by: Shay Agroskin > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index cab83a9de651..97e701222226 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -4156,7 +4156,6 @@ static int ena_probe(struct pci_dev *pdev, > const struct pci_device_id *ent) > struct net_device *netdev; > static int adapters_found; > u32 max_num_io_queues; > - char *queue_type_str; > bool wd_state; > int bars, rc; > > @@ -4334,15 +4333,10 @@ static int ena_probe(struct pci_dev > *pdev, const struct pci_device_id *ent) > timer_setup(&adapter->timer_service, ena_timer_service, > 0); > mod_timer(&adapter->timer_service, round_jiffies(jiffies + > HZ)); > > - if (ena_dev->tx_mem_queue_type == > ENA_ADMIN_PLACEMENT_POLICY_HOST) > - queue_type_str = "Regular"; > - else > - queue_type_str = "Low Latency"; > - > dev_info(&pdev->dev, > - "%s found at mem %lx, mac addr %pM, Placement > policy: %s\n", > + "%s found at mem %lx, mac addr %pM\n", > DEVICE_NAME, (long)pci_resource_start(pdev, 0), > - netdev->dev_addr, queue_type_str); > + netdev->dev_addr); > > set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags); Hi, I got this patchset messed up a little. These patches are part of the 'Update license and polish ENA driver code' patchset (Message-id: <20200913081640.19560-1-shayagr@amazon.com>) Sorry for the clutter. Please let me know it you prefer that I re-send this patchset as a single thread