From: Trammell Hudson <hudson@trmm.net>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info()
Date: Mon, 14 Sep 2020 10:45:32 +0000 [thread overview]
Message-ID: <pqzUSnNRnX2V2C92B6EGpMwCCjcQY39Ev8N4rWuuJLqH35guLwJC7RV4bs1xscYId9EOljNqPPgwMXNhdFW6QV-lnlOfefviwaWTbPb1NUA=@trmm.net> (raw)
In-Reply-To: <20200914090557.GB753@Air-de-Roger>
On Monday, September 14, 2020 5:05 AM, Roger Pau Monné <roger.pau@citrix.com> wrote:
> Thanks! Being picky you likely wan to split this into two separate
> commits: one for adding need_to_free and the other for
> display_file_info. There's no relation between the two that would
> require them to be on the same commit.
Ok. I'll address that in the v4 of the patch.
> [...]
> > +static void __init display_file_info(CHAR16 *name, struct file *file, char *options)
>
> I think name at least could be constified?
Oh, I wish. There should be a major pass to constify the EFI functions.
So many of them are not const-correct and it worries me that
literal strings are passed to those functions.
> Also efi_arch_handle_module seem to do more than just printing file
> info, hence I would likely rename this to handle_file_info to be more
> representative of what it does.
Ok. Fixed in v4.
--
Trammell
next prev parent reply other threads:[~2020-09-14 10:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 19:00 [PATCH v3 0/4] efi: Unified Xen hypervisor/kernel/initrd images Trammell Hudson
2020-09-07 19:00 ` [PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug Trammell Hudson
2020-09-08 9:04 ` Jan Beulich
2020-09-08 9:30 ` Trammell Hudson
2020-09-08 12:29 ` Jan Beulich
2020-09-14 9:14 ` Trammell Hudson
2020-09-14 9:15 ` Jan Beulich
2020-09-07 19:00 ` [PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info() Trammell Hudson
2020-09-14 9:05 ` Roger Pau Monné
2020-09-14 10:45 ` Trammell Hudson [this message]
2020-09-07 19:00 ` [PATCH v3 3/4] efi: Enable booting unified hypervisor/kernel/initrd images Trammell Hudson
2020-09-14 10:06 ` Roger Pau Monné
2020-09-14 11:19 ` Trammell Hudson
2020-09-14 12:14 ` Jan Beulich
2020-09-07 19:00 ` [PATCH v3 4/4] efi: Do not use command line if secure boot is enabled Trammell Hudson
2020-09-14 10:24 ` Roger Pau Monné
2020-09-14 11:36 ` Trammell Hudson
2020-09-14 12:16 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2020-09-07 17:47 [PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info() Trammell Hudson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pqzUSnNRnX2V2C92B6EGpMwCCjcQY39Ev8N4rWuuJLqH35guLwJC7RV4bs1xscYId9EOljNqPPgwMXNhdFW6QV-lnlOfefviwaWTbPb1NUA=@trmm.net' \
--to=hudson@trmm.net \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.