From: "Drew Green via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Drew Green <agreenbhm@gmail.com>, agreenbhm <agreenbhm@gmail.com>
Subject: [PATCH] Added Curl Option to Override Request Method
Date: Tue, 26 Apr 2022 11:01:34 +0000 [thread overview]
Message-ID: <pull.1225.git.1650970894143.gitgitgadget@gmail.com> (raw)
From: agreenbhm <agreenbhm@gmail.com>
Added support for environment variable "CURLOPT_CUSTOMREQUEST"
to allow setting the curl option to override the default request
method used by HTTP Git operations. Primary reason for this is to
allow support for cloning repositories where only GET requests
are allowed but not POSTs. When cloning a repo first a GET is
made to the server and then a POST is made to the "git-upload-pack"
endpoint. In some corporate environments with strong controls
only GET requests are allowed to known repository hosts (such
as GitHub) to prevent data leakage by sending data. Using this
new environmental variable, a user can set
"CURLOPT_CUSTOMREQUEST=GET" which will change the second request
from a POST to a GET, bypassing web proxy restrictions on the type
of requests allowed. Tested with GitHub, changing the request
from POST to GET still results in the expected behavior of the
repo successfully being cloned.
Signed-off-by: agreenbhm <agreenbhm@gmail.com>
---
Added Curl Option to Override Request Method
Added support for environment variable "CURLOPT_CUSTOMREQUEST" to allow
setting the curl option to override the default request method used by
HTTP Git operations. Primary reason for this is to allow support for
cloning repositories where only GET requests are allowed but not POSTs.
When cloning a repo first a GET is made to the server and then a POST is
made to the "git-upload-pack" endpoint. In some corporate environments
with strong controls only GET requests are allowed to known repository
hosts (such as GitHub) to prevent data leakage by sending data. Using
this new environmental variable, a user can set
"CURLOPT_CUSTOMREQUEST=GET" which will change the second request from a
POST to a GET, bypassing web proxy restrictions on the type of requests
allowed. Tested with GitHub, changing the request from POST to GET still
results in the expected behavior of the repo successfully being cloned.
Signed-off-by: agreenbhm agreenbhm@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1225%2Fagreenbhm%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1225/agreenbhm/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1225
http.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/http.c b/http.c
index 229da4d1488..2ca13b848a5 100644
--- a/http.c
+++ b/http.c
@@ -1235,6 +1235,8 @@ struct active_request_slot *get_active_slot(void)
curl_easy_setopt(slot->curl, CURLOPT_HTTPAUTH, http_auth_methods);
if (http_auth.password || curl_empty_auth_enabled())
init_curl_http_auth(slot->curl);
+ if(getenv("CURLOPT_CUSTOMREQUEST"))
+ curl_easy_setopt(slot->curl, CURLOPT_CUSTOMREQUEST, getenv("CURLOPT_CUSTOMREQUEST"));
return slot;
}
base-commit: 6cd33dceed60949e2dbc32e3f0f5e67c4c882e1e
--
gitgitgadget
next reply other threads:[~2022-04-26 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 11:01 Drew Green via GitGitGadget [this message]
2022-04-26 15:57 ` [PATCH v2] Added Curl Option to Override Request Method v2 Drew Green via GitGitGadget
2022-04-26 21:28 ` brian m. carlson
2022-04-26 23:34 ` Drew Green
2022-04-27 0:49 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1225.git.1650970894143.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=agreenbhm@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.