All of lore.kernel.org
 help / color / mirror / Atom feed
From: "erik chen via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v3 0/1] fetch: add trace2 instrumentation
Date: Wed, 06 Nov 2019 19:39:11 +0000	[thread overview]
Message-ID: <pull.451.v3.git.1573069152.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.451.v2.git.1573066300.gitgitgadget@gmail.com>

Add trace2 regions to fetch-pack.c to better track time spent in the various
phases of a fetch:

* matching common remote and local refs
* marking local refs as complete (part of the matching process)

Both of these stages can be slow for repositories with many refs.

Signed-off-by: Erik Chen erikchen@chromium.org [erikchen@chromium.org]

Erik Chen (1):
  fetch: add trace2 instrumentation

 fetch-pack.c | 8 ++++++++
 1 file changed, 8 insertions(+)


base-commit: 566a1439f6f56c2171b8853ddbca0ad3f5098770
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-451%2Ferikchen%2Ftest12-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-451/erikchen/test12-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/451

Range-diff vs v2:

 1:  4fdbb9f504 ! 1:  364c526a5d fetch: add trace2 instrumentation
     @@ -16,10 +16,7 @@
       --- a/fetch-pack.c
       +++ b/fetch-pack.c
      @@
     - 	struct ref *ref;
     - 	int old_save_commit_buffer = save_commit_buffer;
     - 	timestamp_t cutoff = 0;
     --
     + 
       	save_commit_buffer = 0;
       
      +	trace2_region_enter("fetch-pack", "mark_complete_and_common_ref", NULL);
 2:  606756d7db < -:  ---------- add whitespace

-- 
gitgitgadget

  parent reply	other threads:[~2019-11-06 19:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 19:26 [PATCH 0/1] fetch: add trace2 instrumentation erik chen via GitGitGadget
2019-11-05 19:26 ` [PATCH 1/1] " Erik Chen via GitGitGadget
2019-11-06 12:30   ` Johannes Schindelin
2019-11-06 18:51 ` [PATCH v2 0/2] " erik chen via GitGitGadget
2019-11-06 18:51   ` [PATCH v2 1/2] " Erik Chen via GitGitGadget
2019-11-06 18:51   ` [PATCH v2 2/2] add whitespace Erik Chen via GitGitGadget
2019-11-06 19:39   ` erik chen via GitGitGadget [this message]
2019-11-06 19:39     ` [PATCH v3 1/1] fetch: add trace2 instrumentation Erik Chen via GitGitGadget
2019-11-07  5:32       ` Junio C Hamano
2019-11-18 15:46         ` Derrick Stolee
2019-11-19  1:55           ` Junio C Hamano
2019-11-19 21:24             ` Erik Chen
2019-11-19 22:57             ` Erik Chen
2019-11-19 21:51           ` Erik Chen
2019-11-19 21:47         ` Erik Chen
2019-11-07  5:21     ` [PATCH v3 0/1] " Junio C Hamano
2019-11-19 21:44       ` Erik Chen
2019-11-18 14:52     ` [PATCH v4 " erik chen via GitGitGadget
2019-11-18 14:52       ` [PATCH v4 1/1] " Erik Chen via GitGitGadget
2019-11-19 23:02       ` [PATCH v5 0/1] " erik chen via GitGitGadget
2019-11-19 23:02         ` [PATCH v5 1/1] " Erik Chen via GitGitGadget
2019-11-20  1:07           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.451.v3.git.1573069152.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.