All of
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <>
Cc: "Carlo Marcelo Arenas Belón" <>,
	"Johannes Schindelin" <>,
	"Junio C Hamano" <>
Subject: [PATCH 0/1] remote-curl: unbreak http.extraHeader with custom allocators
Date: Tue, 05 Nov 2019 21:59:17 +0000	[thread overview]
Message-ID: <> (raw)

This is one of those bugs that can cost entire days of work.

The symptom of this bug is that git -c http.extraheader push ... will fail
frequently in Git for Windows v2.24.0, but not always. When it fails,
though, it will cause a segmentation fault in git remote-https while calling 
http_cleanup() and leave no visual indication of that problem, the only
indication of a problem will be the exit code of the caller (in this
instance, git push will fail with exit code 1).

In my tests during the pre-release period, I pushed many a time, it probably
failed a lot, in the way indicated above, and due to the absence of any
error message, I failed to realize that there was a problem in the first

Fun side note: this bug haunted me for the best part of yesterday, when I
tried to get Git for Windows v2.24.0 out the door. Large parts of Git for
Windows' release management are scripted, and that script failed, claiming
to have been unsuccessful in pushing the tag, just after
printing a message to the extent that the tag is already up to date (except
in the first attempt, when it reported to have been successful in pushing
the tag). My attempts to fix the release script were doomed to fail because
the root cause was not a bug in the script, but the bug fixed in this patch.

Johannes Schindelin (1):
  remote-curl: unbreak http.extraHeader with custom allocators

 http.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

base-commit: 93b980e58f5624ee4e3b2dc0d0babaa97ef66d19
Fetch-It-Via: git fetch pr-453/dscho/fix-curl-xmalloc-regression-v1

             reply	other threads:[~2019-11-05 21:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 21:59 Johannes Schindelin via GitGitGadget [this message]
2019-11-05 21:59 ` [PATCH 1/1] remote-curl: unbreak http.extraHeader with custom allocators Johannes Schindelin via GitGitGadget
2019-11-06  4:16   ` Jeff King
2019-11-06  9:14     ` Johannes Schindelin
2019-11-06  9:49       ` Junio C Hamano
2019-11-06 19:38         ` Johannes Schindelin
2019-11-08  8:34           ` Junio C Hamano
2019-11-08 13:44             ` Johannes Schindelin
2019-11-06 10:04 ` [PATCH v2 0/1] " Johannes Schindelin via GitGitGadget
2019-11-06 10:04   ` [PATCH v2 1/1] " Johannes Schindelin via GitGitGadget
2019-11-06 11:29     ` Jeff King
2019-11-06 12:12     ` Junio C Hamano
2019-11-06 19:34       ` Johannes Schindelin
2019-11-07  5:39         ` Junio C Hamano
2019-11-07 12:40           ` Johannes Schindelin
2019-11-08  3:03             ` Junio C Hamano
2019-11-06 12:15   ` [PATCH v2 0/1] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.