From: "Vasil Dimov via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Vasil Dimov <vd@freebsd.org>
Subject: [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output
Date: Wed, 15 Apr 2020 20:32:23 +0000 [thread overview]
Message-ID: <pull.760.v2.git.git.1586982745.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.760.git.git.1586960921.gitgitgadget@gmail.com>
* override a possibly user-customized format.pretty that would render git
log output unparsable by git range-diff
* don't use negative string precision, e.g. "%.*s", -5, "foo"
Changes since v1:
* Fixed a typo in the commit message (found by Taylor Blau)
Vasil Dimov (2):
range-diff: fix a crash in parsing git-log output
range-diff: avoid negative string precision
range-diff.c | 18 +++++++++++++++++-
t/t3206-range-diff.sh | 10 ++++++++++
2 files changed, 27 insertions(+), 1 deletion(-)
base-commit: de49261b050d9cd8ec73842356077bc5b606640f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-760%2Fvasild%2Frange-diff-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-760/vasild/range-diff-v2
Pull-Request: https://github.com/git/git/pull/760
Range-diff vs v1:
1: 2375e34100e = 1: 2375e34100e range-diff: fix a crash in parsing git-log output
2: b3384880c72 ! 2: 72fddcff554 range-diff: avoid negative string precision
@@ Metadata
## Commit message ##
range-diff: avoid negative string precision
- If the supplied integer for "precisoin" is negative in
+ If the supplied integer for "precision" is negative in
`"%.*s", len, line` then it is ignored. So the current code is
equivalent to just `"%s", line` because it is executed only if
`len` is negative.
--
gitgitgadget
next prev parent reply other threads:[~2020-04-15 20:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 14:28 [PATCH 0/2] range-diff: fix a crash in parsing git-log output Vasil Dimov via GitGitGadget
2020-04-15 14:28 ` [PATCH 1/2] " Vasil Dimov via GitGitGadget
2020-04-15 15:31 ` Junio C Hamano
2020-04-15 16:16 ` Vasil Dimov
2020-04-15 16:23 ` Jeff King
2020-04-15 22:02 ` Taylor Blau
2020-04-15 22:29 ` Jeff King
2020-04-15 16:13 ` Taylor Blau
2020-04-15 14:28 ` [PATCH 2/2] range-diff: avoid negative string precision Vasil Dimov via GitGitGadget
2020-04-15 16:20 ` Taylor Blau
2020-04-15 20:19 ` Vasil Dimov
2020-04-15 20:32 ` Vasil Dimov via GitGitGadget [this message]
2020-04-15 20:32 ` [PATCH v2 1/2] range-diff: fix a crash in parsing git-log output Vasil Dimov via GitGitGadget
2020-04-15 20:32 ` [PATCH v2 2/2] range-diff: avoid negative string precision Vasil Dimov via GitGitGadget
2020-04-16 1:07 ` [PATCH v2 0/2] range-diff: fix a crash in parsing git-log output Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.760.v2.git.git.1586982745.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=vd@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.