From: "Dima Kov via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Dima Kov <dima.kovol@gmail.com>, Dima Kov <dima.kovol@gmail.com>
Subject: [PATCH] refactor of git_setup_gettext method
Date: Sun, 30 May 2021 21:42:42 +0000 [thread overview]
Message-ID: <pull.964.git.1622410962551.gitgitgadget@gmail.com> (raw)
From: Dima Kov <dima.kovol@gmail.com>
Use one "free" call at the end of the function,
instead of being dependent on the execution flow.
Signed-off-by: Dima Kov <dima.kovol@gmail.com>
---
refactor of git_setup_gettext method
Use one "free" call at the end of the function, instead of being
dependent on the execution flow.
Signed-off-by: Dima Kov dima.kovol@gmail.com
Hi. My first PR fot Git repository. I went over the code and saw that
maybe this part can be more clearer. Thanks.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-964%2Fdimakov%2Ffree_opt-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-964/dimakov/free_opt-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/964
gettext.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/gettext.c b/gettext.c
index af2413b47e85..e75c7bfdb1a8 100644
--- a/gettext.c
+++ b/gettext.c
@@ -109,17 +109,14 @@ void git_setup_gettext(void)
if (!podir)
podir = p = system_path(GIT_LOCALE_PATH);
- if (!is_directory(podir)) {
- free(p);
- return;
+ if (is_directory(podir)) {
+ bindtextdomain("git", podir);
+ setlocale(LC_MESSAGES, "");
+ setlocale(LC_TIME, "");
+ init_gettext_charset("git");
+ textdomain("git");
}
- bindtextdomain("git", podir);
- setlocale(LC_MESSAGES, "");
- setlocale(LC_TIME, "");
- init_gettext_charset("git");
- textdomain("git");
-
free(p);
}
base-commit: de88ac70f3a801262eb3aa087e5d9a712be0a54a
--
gitgitgadget
next reply other threads:[~2021-05-30 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 21:42 Dima Kov via GitGitGadget [this message]
2021-05-30 22:14 ` [PATCH] refactor of git_setup_gettext method Eric Sunshine
2021-05-31 1:54 ` Junio C Hamano
2021-05-31 3:42 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.964.git.1622410962551.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=dima.kovol@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.