All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [ulogd2 PATCH 08/13] build: only conditionally enter sub-directories containing optional code
Date: Sat, 30 Oct 2021 19:15:08 +0200 (CEST)	[thread overview]
Message-ID: <q66o80p6-878q-15pr-roo7-3po7395878r0@vanv.qr> (raw)
In-Reply-To: <20211030160141.1132819-9-jeremy@azazel.net>


On Saturday 2021-10-30 18:01, Jeremy Sowden wrote:
>diff --git a/input/Makefile.am b/input/Makefile.am
>index 8f2e934fcdfa..668fc2b1444a 100644
>--- a/input/Makefile.am
>+++ b/input/Makefile.am
>@@ -1 +1,9 @@
>-SUBDIRS = packet flow sum
>+if BUILD_NFCT
>+    OPT_SUBDIR_FLOW = flow
>+endif
>+
>+if BUILD_NFACCT
>+    OPT_SUBDIR_SUM = sum
>+endif
>+
>+SUBDIRS = packet $(OPT_SUBDIR_FLOW) $(OPT_SUBDIR_SUM)

You use += in a previous patch, so why not use it here as well.

SUBDIRS = packet
if BUILD_NFCT
SUBDIRS += flow
endif
if BUILD_NFACCT
SUBDIRS += sum
endif


  reply	other threads:[~2021-10-30 17:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 16:01 [ulogd2 PATCH 00/13] Build Improvements Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 01/13] gitignore: Add Emacs artefacts Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 02/13] gitignore: ignore util/.dirstamp Jeremy Sowden
2021-10-30 17:05   ` Jan Engelhardt
2021-11-06 11:06     ` Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 03/13] build: remove unused Makefile fragment Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 04/13] build: remove empty filter sub-directory Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 05/13] build: move cpp flag to the only Makefile.am file where it's needed Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 06/13] build: add Make_global.am for common flags and include it where necessary Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 07/13] build: use `dist_man_MANS` Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 08/13] build: only conditionally enter sub-directories containing optional code Jeremy Sowden
2021-10-30 17:15   ` Jan Engelhardt [this message]
2021-11-06 11:06     ` Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 09/13] build: move library dependencies from LDFLAGS to LIBADD Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 10/13] build: update obsolete autoconf macros Jeremy Sowden
2021-10-30 17:16   ` Jan Engelhardt
2021-11-06 11:07     ` Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 11/13] build: quote and reformat some autoconf macro arguments Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 12/13] build: reformat autoconf AC_ARG_WITH, AC_ARG_ENABLE and related macros Jeremy Sowden
2021-10-30 16:01 ` [ulogd2 PATCH 13/13] build: bump autoconf version to 2.71 Jeremy Sowden
2021-10-30 17:21   ` Jan Engelhardt
2021-11-06 11:07     ` Jeremy Sowden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q66o80p6-878q-15pr-roo7-3po7395878r0@vanv.qr \
    --to=jengelh@inai.de \
    --cc=jeremy@azazel.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.