From: Trammell Hudson <hudson@trmm.net>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"wl@xen.org" <wl@xen.org>
Subject: Re: [PATCH v8 4/5] efi: Enable booting unified hypervisor/kernel/initrd images
Date: Fri, 02 Oct 2020 10:52:27 +0000 [thread overview]
Message-ID: <s3f2INKZyF2RmtGWXAIMvThTOOBmykDEZvbEAlTOvNW6J3GaMSr7Q5oMo-IXI2E9cXGOzyqefPTMt6BhBL3-M0B40Otjgw0ANKS-Iuo3q7g=@trmm.net> (raw)
In-Reply-To: <ab61cb4b-bcbe-fb61-50d7-8d93bcfca4ab@suse.com>
On Friday, October 2, 2020 4:27 AM, Jan Beulich <jbeulich@suse.com> wrote:
> On 30.09.2020 14:00, Trammell Hudson wrote:
> > - /* Read and parse the config file. */
>
> I'm sorry for noticing this only now, but I don't think this comment
> should be moved. If no other need for a v9 arises, this can likely
> be undone while committing.
I'll relocate it.
> > - if ( sect->Name[0] != '.' )
> > - return -1;
>
> I was about to say "'true' please", but you really mean 'false"
> now. (Could perhaps again be fixed while committing.)
oops oops. Yes, that is a mistake. Should be false; I'll
fix it.
> [...]
> Just as a remark (and again spotting only now) this could be had
> with one less comparison:
>
> if ( cw != c )
> return false;
> if ( c == '\0' )
> return true;
>
> At which the need for cw also disappears.
Sure. I'll fix that, too.
Since there are a few patches to the patch, I'll send out a v9 so
that we don't forget any of the ones that we wanted to remember to make.
--
Trammell
next prev parent reply other threads:[~2020-10-02 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 12:00 [PATCH v8 0/5] efi: Unified Xen hypervisor/kernel/initrd images Trammell Hudson
2020-09-30 12:00 ` [PATCH v8 1/5] efi/boot.c: add file.need_to_free Trammell Hudson
2020-10-02 8:15 ` Jan Beulich
2020-09-30 12:00 ` [PATCH v8 2/5] efi/boot.c: add handle_file_info() Trammell Hudson
2020-09-30 12:00 ` [PATCH v8 3/5] efi/boot.c: wrap PrintStr/PrintErr to allow const CHAR16* arguments Trammell Hudson
2020-09-30 12:15 ` Jan Beulich
2020-09-30 12:33 ` Trammell Hudson
2020-09-30 12:00 ` [PATCH v8 4/5] efi: Enable booting unified hypervisor/kernel/initrd images Trammell Hudson
2020-10-02 8:27 ` Jan Beulich
2020-10-02 10:52 ` Trammell Hudson [this message]
2020-09-30 12:00 ` [PATCH v8 5/5] efi: Do not use command line if unified config is included Trammell Hudson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='s3f2INKZyF2RmtGWXAIMvThTOOBmykDEZvbEAlTOvNW6J3GaMSr7Q5oMo-IXI2E9cXGOzyqefPTMt6BhBL3-M0B40Otjgw0ANKS-Iuo3q7g=@trmm.net' \
--to=hudson@trmm.net \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.