All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jeremy Soller <jeremy@system76.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Headset microphone support for System76 darp5
Date: Wed, 30 Jan 2019 18:34:42 +0100	[thread overview]
Message-ID: <s5h1s4ucaml.wl-tiwai@suse.de> (raw)
In-Reply-To: <1548791521.3450804.1646371736.7EA213CA@webmail.messagingengine.com>

On Tue, 29 Jan 2019 20:52:01 +0100,
Jeremy Soller wrote:
> 
> Headset microphone support for System76 darp5

The changes look mostly OK, but could you give a bit more details?

> @@ -6606,6 +6616,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED),
>         SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY),
> +       SND_PCI_QUIRK(0x1558, 0x1325, "System76", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>         /* ALC282 */
>         SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
>         SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),

We keep the list in the ID number order, so please put at the
appropriate place.


thanks,

Takashi

  reply	other threads:[~2019-01-30 17:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 19:52 [PATCH] Headset microphone support for System76 darp5 Jeremy Soller
2019-01-30 17:34 ` Takashi Iwai [this message]
2019-01-30 23:07   ` Jeremy Soller
2019-01-30 23:12     ` Jeremy Soller
2019-01-31 11:35       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1s4ucaml.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeremy@system76.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.