From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbdHXQGY (ORCPT ); Thu, 24 Aug 2017 12:06:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:34654 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751840AbdHXQGX (ORCPT ); Thu, 24 Aug 2017 12:06:23 -0400 Date: Thu, 24 Aug 2017 18:06:20 +0200 Message-ID: From: Takashi Iwai To: Tom Rini Cc: Mark Brown , Linus Torvalds , alsa-devel@alsa-project.org, Liam Girdwood , Andy Shevchenko , Bard Liao , Oder Chiou , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs In-Reply-To: <20170824155437.GF17193@bill-the-cat> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503498573.25945.69.camel@linux.intel.com> <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat> <20170824144152.GC17193@bill-the-cat> <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk> <20170824155437.GF17193@bill-the-cat> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2017 17:54:37 +0200, Tom Rini wrote: > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote: > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote: > > > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid > > > fix (and remove again in 4.14). > > > > > The former is cleaner, but it's bigger, while the latter is a safer > > > oneliner at the late RC stage. > > > > > I leave the decision to Mark. > > > > I'm happier with the oneline change TBH, like you say it's pretty late > > in the release cycle. Can you just apply the patch directly and send it > > to Linus with my ack or should I put together a pull request? > > FWIW, I'd be happy to give the change a quick spin and Tested-by it. Well, it's your patch, after all :) Below is the patch I'm going to queue. Takashi -- 8< -- From: Tom Rini Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. [ More background note: the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...") moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper acpi_device_id table. Although the action itself is correct per se, the overseen issue is the reference id->driver_data at rt5677_i2c_probe() for retrieving the corresponding chip model for the given id. Since id=NULL is passed for ACPI matching case, we get an Oops now. We already have queued more fixes for 4.14 and they already address the issue, but they are bigger changes that aren't preferable for the late 4.13-rc stage. So, this patch just papers over the bug as a once-off quick fix for a particular ACPI matching. -- tiwai ] Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Signed-off-by: Tom Rini Acked-by: Mark Brown Signed-off-by: Takashi Iwai --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = { static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); -- 2.14.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Date: Thu, 24 Aug 2017 18:06:20 +0200 Message-ID: References: <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503498573.25945.69.camel@linux.intel.com> <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat> <20170824144152.GC17193@bill-the-cat> <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk> <20170824155437.GF17193@bill-the-cat> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 21CDE266DE5 for ; Thu, 24 Aug 2017 18:06:21 +0200 (CEST) In-Reply-To: <20170824155437.GF17193@bill-the-cat> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Tom Rini Cc: Oder Chiou , alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Bard Liao , Andy Shevchenko , Linus Torvalds List-Id: alsa-devel@alsa-project.org On Thu, 24 Aug 2017 17:54:37 +0200, Tom Rini wrote: > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote: > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote: > > > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid > > > fix (and remove again in 4.14). > > > > > The former is cleaner, but it's bigger, while the latter is a safer > > > oneliner at the late RC stage. > > > > > I leave the decision to Mark. > > > > I'm happier with the oneline change TBH, like you say it's pretty late > > in the release cycle. Can you just apply the patch directly and send it > > to Linus with my ack or should I put together a pull request? > > FWIW, I'd be happy to give the change a quick spin and Tested-by it. Well, it's your patch, after all :) Below is the patch I'm going to queue. Takashi -- 8< -- From: Tom Rini Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. [ More background note: the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...") moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper acpi_device_id table. Although the action itself is correct per se, the overseen issue is the reference id->driver_data at rt5677_i2c_probe() for retrieving the corresponding chip model for the given id. Since id=NULL is passed for ACPI matching case, we get an Oops now. We already have queued more fixes for 4.14 and they already address the issue, but they are bigger changes that aren't preferable for the late 4.13-rc stage. So, this patch just papers over the bug as a once-off quick fix for a particular ACPI matching. -- tiwai ] Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Signed-off-by: Tom Rini Acked-by: Mark Brown Signed-off-by: Takashi Iwai --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = { static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); -- 2.14.0