From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756272Ab0GLPxf (ORCPT ); Mon, 12 Jul 2010 11:53:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42861 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755852Ab0GLPxe (ORCPT ); Mon, 12 Jul 2010 11:53:34 -0400 Date: Mon, 12 Jul 2010 17:53:32 +0200 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , LKML , John Kacur , Frederic Weisbecker , ALSA development Subject: Re: [PATCH 3/3] sound: push BKL into open functions In-Reply-To: <201007111216.36538.arnd@arndb.de> References: <1278798701-11171-1-git-send-email-arnd@arndb.de> <1278798701-11171-4-git-send-email-arnd@arndb.de> <201007111216.36538.arnd@arndb.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 11 Jul 2010 12:16:36 +0200, Arnd Bergmann wrote: > > This moves the lock_kernel() call from soundcore_open > to the individual OSS device drivers, where we can deal > with it one driver at a time if needed, or just kill > off the drivers. > > All core components in ALSA already provide > adequate locking in their open()-functions > and do not require the big kernel lock, so > there is no need to add the BKL there. > > Signed-off-by: Arnd Bergmann > --- > On Sunday 11 July 2010 09:15:22 Jaroslav Kysela wrote: > > I don't see any reason (benefit) to add gotos to these two functions. > > > Sorry, I had removed them and then forgot the git-add before > creating the emails. Originally, I had two patches, one for > pushing down the BKL into every sound driver (hence the goto) > and a second patch to remove the BKL again from all the native > alsa drivers. If you prefer, I can also give you the separate > patches, but I figured that since none of the ALSA drivers needs > the BKL, the combined patch would be better. > > This is the corrected combined version. Thanks. I applied now to sound git tree (with a minor fix of coding-style in sound/oss/au1550_ac97.c). BTW, do you have an updated patch for native_ioctl conversion wrt sound/*? Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 3/3] sound: push BKL into open functions Date: Mon, 12 Jul 2010 17:53:32 +0200 Message-ID: References: <1278798701-11171-1-git-send-email-arnd@arndb.de> <1278798701-11171-4-git-send-email-arnd@arndb.de> <201007111216.36538.arnd@arndb.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 78F5F244CD for ; Mon, 12 Jul 2010 17:53:33 +0200 (CEST) In-Reply-To: <201007111216.36538.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Arnd Bergmann Cc: John Kacur , Frederic Weisbecker , ALSA development , LKML List-Id: alsa-devel@alsa-project.org At Sun, 11 Jul 2010 12:16:36 +0200, Arnd Bergmann wrote: > > This moves the lock_kernel() call from soundcore_open > to the individual OSS device drivers, where we can deal > with it one driver at a time if needed, or just kill > off the drivers. > > All core components in ALSA already provide > adequate locking in their open()-functions > and do not require the big kernel lock, so > there is no need to add the BKL there. > > Signed-off-by: Arnd Bergmann > --- > On Sunday 11 July 2010 09:15:22 Jaroslav Kysela wrote: > > I don't see any reason (benefit) to add gotos to these two functions. > > > Sorry, I had removed them and then forgot the git-add before > creating the emails. Originally, I had two patches, one for > pushing down the BKL into every sound driver (hence the goto) > and a second patch to remove the BKL again from all the native > alsa drivers. If you prefer, I can also give you the separate > patches, but I figured that since none of the ALSA drivers needs > the BKL, the combined patch would be better. > > This is the corrected combined version. Thanks. I applied now to sound git tree (with a minor fix of coding-style in sound/oss/au1550_ac97.c). BTW, do you have an updated patch for native_ioctl conversion wrt sound/*? Takashi