From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: patch to support Samsung NC10 mini notebook
Date: Tue, 12 May 2009 08:13:12 +0200
Message-ID: <s5h1vquvog7.wl%tiwai@suse.de>
References: <2b491faa0905101221p6ba903d9kc5be3cc4869f4926@mail.gmail.com>
	<s5hws8oaval.wl%tiwai@suse.de>
	<2b491faa0905111325h5142b5c9s2ee0f0030606e550@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 022DD246B5
	for <alsa-devel@alsa-project.org>;
	Tue, 12 May 2009 08:13:13 +0200 (CEST)
In-Reply-To: <2b491faa0905111325h5142b5c9s2ee0f0030606e550@mail.gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Chris Pockele <chris.pockele.f1@gmail.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Mon, 11 May 2009 22:25:14 +0200,
Chris Pockele wrote:
> =

> >> =A0 =A0 =A0 [ALC663_ASUS_MODE6] =3D "asus-mode6",
> >> + =A0 =A0 [ALC272_DELL] =3D "dell272",
> >> + =A0 =A0 [ALC272_DELL_ZM1] =3D "dell-zm1",
> >
> > These models have been already added pretty recently.
> > Please rebase your patch with the latest snapshot.
> >
> I rebased using 20090509 snapshot before sending the patch (I checked
> out today's snapshot too - patch_realtek.c hasn't changed), and those
> models were there indeed.  However, I wanted to try those
> configurations but I couldn't use the model=3D option because the
> configurations were not in the alc662_models array.  That's why I
> added these 2 lines, and it got through to the patch.  I removed them
> for now, as that should probably be another patch.

Hm, the model strings should have been there, at least, in
alsa-driver-snapshot.tar.gz.  The snapshot.tar.gz is always the latest
tarball.  Anyway, the change is trivial, so I fixed manually.

> >> + =A0 =A0 [ALC272_SAMSUNG_NC10] =3D "samsung-nc10",
> >
> > Also, don't forget to update
> > Documentation/sound/alsa/HD-Audio-Models.txt, too.
> >
> >
> > Could you fix the issues above and repost?
> >
> The attached version fixes all issues you mentioned.

Thanks!  Now applied to sound git tree.


Takashi