From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D605CC433F5 for ; Tue, 19 Apr 2022 07:01:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 531FF10EEB2; Tue, 19 Apr 2022 07:01:37 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE5C810EEB2 for ; Tue, 19 Apr 2022 07:01:35 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 5F3882112B; Tue, 19 Apr 2022 07:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1650351694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVrxI7k1ifm5AVHxBNA4vg7g3DvfNn+i52sKD4CT/7c=; b=yvqQEPUaxXn5KdShiAjhnM9VU/RVcB/rY2uDynwP1oUg1mPBMsi+qb+Y/U/DnL0G++hH4h SWcElFyY1kqEGX5ieutAjOstFiFZn6PgiHb0zfelESoMdZ29Orr/EZZ+OUwwKchvissEes YiSK/qrA8zCzFDyA+4azrki0XDGFEfU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1650351694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVrxI7k1ifm5AVHxBNA4vg7g3DvfNn+i52sKD4CT/7c=; b=Mni+J2F2Ixk0cEGqa+xf3AfdNYY8/xNsoe5B0CSeEkAMSomAUjmlpZii2y5qMgsOB2KHt1 7OB4EvB15pToP4Bw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4BD4CA3BAD; Tue, 19 Apr 2022 07:01:34 +0000 (UTC) Date: Tue, 19 Apr 2022 09:01:34 +0200 Message-ID: From: Takashi Iwai To: Lucas De Marchi In-Reply-To: <20220416064418.2364582-1-lucas.demarchi@intel.com> References: <20220416064418.2364582-1-lucas.demarchi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, 16 Apr 2022 08:44:18 +0200, Lucas De Marchi wrote: > > pci_get_class() will already unref the pci device passed as argument. > So if it's unconditionally unref'ed, even if the loop is not stopped, > there will be one too many unref for each device not matched. > > Cc: Kai Vehmanen > Cc: Takashi Iwai > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 > Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching display") > Signed-off-by: Lucas De Marchi Thanks, applied now. But the Fixes commit id was wrong. I corrected to the right upstream one, c9db8a30d9f0. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B19BBC433F5 for ; Tue, 19 Apr 2022 07:02:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A45E9826; Tue, 19 Apr 2022 09:01:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A45E9826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650351754; bh=86UcdBzNLy132ueDh2DtqcaruOSrAN0kVZUzioiVKt4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a0RPI9fYnosdLH5sdq/JeCg5I3Wrx0MQyOHkcPAM/b3qk9wjDYdEUDhy2XjYD9LxE 4t7zuJ4xgP0IZ5nZvxgkk7DT9ZrEOk/NDpCIfNsNE169uV2STURxn2aUqqv+Qy0aHp qLfTA8Z7LiN06O1JtIGuGgU+7Yvg67b0BZU63J1Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2CA4CF80121; Tue, 19 Apr 2022 09:01:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27975F8025D; Tue, 19 Apr 2022 09:01:42 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 405B1F80121 for ; Tue, 19 Apr 2022 09:01:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 405B1F80121 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yvqQEPUa"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Mni+J2F2" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 5F3882112B; Tue, 19 Apr 2022 07:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1650351694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVrxI7k1ifm5AVHxBNA4vg7g3DvfNn+i52sKD4CT/7c=; b=yvqQEPUaxXn5KdShiAjhnM9VU/RVcB/rY2uDynwP1oUg1mPBMsi+qb+Y/U/DnL0G++hH4h SWcElFyY1kqEGX5ieutAjOstFiFZn6PgiHb0zfelESoMdZ29Orr/EZZ+OUwwKchvissEes YiSK/qrA8zCzFDyA+4azrki0XDGFEfU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1650351694; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVrxI7k1ifm5AVHxBNA4vg7g3DvfNn+i52sKD4CT/7c=; b=Mni+J2F2Ixk0cEGqa+xf3AfdNYY8/xNsoe5B0CSeEkAMSomAUjmlpZii2y5qMgsOB2KHt1 7OB4EvB15pToP4Bw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4BD4CA3BAD; Tue, 19 Apr 2022 07:01:34 +0000 (UTC) Date: Tue, 19 Apr 2022 09:01:34 +0200 Message-ID: From: Takashi Iwai To: Lucas De Marchi Subject: Re: [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put() In-Reply-To: <20220416064418.2364582-1-lucas.demarchi@intel.com> References: <20220416064418.2364582-1-lucas.demarchi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org, Kai Vehmanen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 16 Apr 2022 08:44:18 +0200, Lucas De Marchi wrote: > > pci_get_class() will already unref the pci device passed as argument. > So if it's unconditionally unref'ed, even if the loop is not stopped, > there will be one too many unref for each device not matched. > > Cc: Kai Vehmanen > Cc: Takashi Iwai > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 > Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching display") > Signed-off-by: Lucas De Marchi Thanks, applied now. But the Fixes commit id was wrong. I corrected to the right upstream one, c9db8a30d9f0. Takashi