From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only
Date: Wed, 11 Mar 2020 18:21:21 +0100 [thread overview]
Message-ID: <s5h36ae7qpa.wl-tiwai@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2003111843440.2957@eliteleevi.tm.intel.com>
On Wed, 11 Mar 2020 18:04:24 +0100,
Kai Vehmanen wrote:
>
> Hey,
>
> On Wed, 11 Mar 2020, Takashi Iwai wrote:
>
> > The remaining question is whether this display_power() call is still
> > needed for the recent chips. Basically it's there for HSW/BDW type
> > chips that need already the power for the HDA link that is dedicated
> > to HDMI. That is, a patch like below could work for the recent chips
>
> yes, it is still needed. The newer chips (GLK, ICL and newer) have added
> sw logic in i915 get_power() that must be run before audio controller is
> initialized. So calling display_power() here is actually more critical
> than before, power up from codec driver is too late. If it's not done,
> you'll get verbs timing out (unless power management is disabled on i915
> side).
Alright, then it's an unavoidable case. Then it seems rather natural
to limit the CDCLK statically when the audio device is present on the
system, rather than too frequent up and down...
Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-11 17:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 14:00 [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only Kai Vehmanen
2019-12-31 14:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only (rev2) Patchwork
2019-12-31 20:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-01-02 18:28 ` [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only Rodrigo Vivi
2020-01-03 15:28 ` Kai Vehmanen
2020-01-06 16:49 ` Matt Roper
2020-03-06 16:45 ` Kai Vehmanen
2020-03-09 10:54 ` Takashi Iwai
2020-03-10 11:20 ` Kai Vehmanen
2020-03-10 13:41 ` Ville Syrjälä
2020-03-10 17:18 ` Kai Vehmanen
2020-03-10 18:25 ` Ville Syrjälä
2020-03-10 19:13 ` Takashi Iwai
2020-03-11 12:16 ` Kai Vehmanen
[not found] ` <s5hk13q7uf6.wl-tiwai@suse.de>
2020-03-11 17:04 ` Kai Vehmanen
2020-03-11 17:21 ` Takashi Iwai [this message]
2020-03-12 17:27 ` Kai Vehmanen
2020-03-12 17:48 ` Ville Syrjälä
2020-03-12 17:50 ` Ville Syrjälä
2020-03-13 14:54 ` Kai Vehmanen
2020-03-11 20:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only (rev3) Patchwork
2020-03-11 20:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-12 13:05 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36ae7qpa.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.