From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D09F2C2D0C6 for ; Sat, 28 Dec 2019 08:26:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5C8221582 for ; Sat, 28 Dec 2019 08:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CpLD81Wz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C8221582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C79231750; Sat, 28 Dec 2019 09:25:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C79231750 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1577521574; bh=jRPp/d2s0JJMkbxcgcrk3ZtpWhhv3EsZv9zRWVggL34=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CpLD81WzTDZPhjdvDVnn5FcPNH5n/FPHMmHG4jVYRRnkmv7leA2g9yse/2n3VXNWd cWN09TT5f2BaZWcx24FUhAkVGZLK3Ye2KzgyTSOHt4bKmxdFX/TMllDhhHImf52CJd slAoniLP0Khj9+9WayL2lAg+hZRzoVLCjV1/fraA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3A74BF8011E; Sat, 28 Dec 2019 09:25:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86B13F800AE; Sat, 28 Dec 2019 09:25:22 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DD0DEF800AE for ; Sat, 28 Dec 2019 09:25:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DD0DEF800AE X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 99332AB98; Sat, 28 Dec 2019 08:25:18 +0000 (UTC) Date: Sat, 28 Dec 2019 09:25:18 +0100 Message-ID: From: Takashi Iwai To: Mark Brown In-Reply-To: <20191227224133.GL27497@sirena.org.uk> References: <20191204151454.21643-1-tiwai@suse.de> <20191227000818.GF27497@sirena.org.uk> <20191227224133.GL27497@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ASoC: core: Fix access to uninitialized list heads X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 27 Dec 2019 23:41:33 +0100, Mark Brown wrote: > > On Fri, Dec 27, 2019 at 08:28:05AM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > Please don't send content free pings and please allow a reasonable time > > > for review. People get busy, go on holiday, attend conferences and so > > > on so unless there is some reason for urgency (like critical bug fixes) > > > please allow at least a couple of weeks for review. If there have been > > > review comments then people may be waiting for those to be addressed. > > > > Sending content free pings adds to the mail volume (if they are seen at > > > all) which is often the problem and since they can't be reviewed > > > directly if something has gone wrong you'll have to resend the patches > > > anyway, so sending again is generally a better approach though there are > > > some other maintainers who like them - if in doubt look at how patches > > > for the subsystem are normally handled. > > > This warning doesn't seem fit at all. The patch was submitted three > > weeks ago. > > There's two bits there - one is that it's adding to the mail > volume when people chase up, the other is that if things have > been lost then almost always the answer is that I don't have the > patch any more (or it'll be error prone to find) and it'll need a > resend so it's better to chase up by resending the patch since > that can be acted on directly. Well, I see a few points to be revised in this policy: - If it were actually your oversight, then resending the patch makes sense. But if it's not merged by other reasons? Silently resending a patch can be worse. For example, suppose the submitter either overlooked or didn't receive a reply or a followup in the thread. You didn't apply the patch because of the reply/followup pointing some problem. Now, the submitter tries to resend the original patch again without asking the situation, just because you suggested so in the past. You'll get the problematic patch again, and there is a risk that the patch gets merged mistakenly at this time. - The mail archive (lore.kernel.org) nowadays catches all posted mails in a proper manner, and it's pretty easy to fetch. And, resending the whole patch would be even higher volume than replying, disconnecting the discussions in the previous thread. So, I find it's OK to give this kind of warning for educational purposes to the people who don't know the common practice and send the patches too frequently. But for other cases, such a warning doesn't fit. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel