From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC78C072B5 for ; Fri, 24 May 2019 05:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB1D02081C for ; Fri, 24 May 2019 05:55:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388518AbfEXFzX (ORCPT ); Fri, 24 May 2019 01:55:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:51720 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387703AbfEXFzX (ORCPT ); Fri, 24 May 2019 01:55:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 40913AEA1; Fri, 24 May 2019 05:55:22 +0000 (UTC) Date: Fri, 24 May 2019 07:55:21 +0200 Message-ID: From: Takashi Iwai To: " Gustavo A. R. Silva " Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: Use struct_size() helper In-Reply-To: <20190523202917.GA12595@embeddedor> References: <20190523202917.GA12595@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 May 2019 22:29:17 +0200, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel) > > with: > > struct_size(data, channels, src_format->channels) > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied now, thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: Use struct_size() helper Date: Fri, 24 May 2019 07:55:21 +0200 Message-ID: References: <20190523202917.GA12595@embeddedor> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190523202917.GA12595@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: " Gustavo A. R. Silva " Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 23 May 2019 22:29:17 +0200, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel) > > with: > > struct_size(data, channels, src_format->channels) > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied now, thanks. Takashi