From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v4 14/14] ASoC: SOF: Add utils
Date: Thu, 14 Feb 2019 14:37:37 +0100
Message-ID: <s5h36oqze1q.wl-tiwai@suse.de>
References: <20190213220734.10471-1-pierre-louis.bossart@linux.intel.com>
 <20190213220734.10471-15-pierre-louis.bossart@linux.intel.com>
 <s5h4l96ze8l.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
In-Reply-To: <s5h4l96ze8l.wl-tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, andriy.shevchenko@intel.com, Keyon Jie <yang.jie@linux.intel.com>, Daniel Baluta <daniel.baluta@gmail.com>, liam.r.girdwood@linux.intel.com, vkoul@kernel.org, broonie@kernel.org, Alan Cox <alan@linux.intel.com>, sound-open-firmware@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Thu, 14 Feb 2019 14:33:30 +0100,
Takashi Iwai wrote:
> 
> On Wed, 13 Feb 2019 23:07:34 +0100,
> Pierre-Louis Bossart wrote:
> > 
> > +void sof_io_write(struct snd_sof_dev *sdev, void __iomem *addr, u32 value)
> > +{
> > +	writel(value, addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_write);
> > +
> > +u32 sof_io_read(struct snd_sof_dev *sdev, void __iomem *addr)
> > +{
> > +	return readl(addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_read);
> > +
> > +void sof_io_write64(struct snd_sof_dev *sdev, void __iomem *addr, u64 value)
> > +{
> > +	writeq(value, addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_write64);
> > +
> > +u64 sof_io_read64(struct snd_sof_dev *sdev, void __iomem *addr)
> > +{
> > +	return readq(addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_read64);
> 
> What's the merit of these wrappers?
> Even if they are good for consistency, they can be well inlined.

OK, now it's clear after reading the other series.

It'd be helpful to add some notes mentioning that these are commonly
set to snd_sof_dsp_ops.


thanks,

Takashi