From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELuW3mLR8w9wkbVGNA+RB9xiIIcTmjGUKlsnndPeTtn7fGQXpFmD5tUMTNXP6xx81aw2Wrfi ARC-Seal: i=1; a=rsa-sha256; t=1521476433; cv=none; d=google.com; s=arc-20160816; b=bHpmXDNeBJdUe/h0MdqLnZ0WTM046Rr0amy4l0i9aBBX/3NnnZxt5UckHFtD6v3UoV md8NFk24RpEkmJipVULO9vJ4jDy+Qo3sDKLzArQeOYkFOM5nk27MS+UtS72rODZuWlZu HecjpX9sXkj0bEQ9Ka5UnRCk+HTnHF5sytGmgHVI3+W+/W4Y7bU42qTNAz6MkP76Vpds RkiR9fOc838sIhOO7a1GSd2qGMNxeYLqpn4YWkVuTr4PkaT1rpY92Q4SBOc1GodzseHa rfJnzo+u8KmhBh6wr8JTNvcxOrFDfTP5XY5JFogjXkw0i5h5ifA9mEIhiHs8tdGiAO9D HS8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:arc-authentication-results; bh=fI1mGfK36KfzpTJaF+JkqWXM1t/3UrpVIQUPmSBsi5A=; b=XeHE09VLidJAkfGxW8f8q1tr1mTp7uxh/MOojw2ZHXVwUrS49vGw183GVVqQjXMT4H IaBcCw0mFmQEpQp7oL1S9WJygrPEb5lAnYWC9OBUXTiaiUf8/sWrN0X/ET4T0v31C7I6 mOdYDNb7mV7R3aHpYlXthtcrrZTuzDnsb7rClqk4b5/nj1FyvFqlTKh9G86cHzP4B64c wd51f7LKijwWyPXa/ntr8YCWIlcquCXeFBbbTxNx5Mk0U+yokfg5FFEg3ClcmHcismR0 q/f9Fuk4UOLpPnib37ro+xTszsjxlfJEAYC8bMBRNyoBI/cn6ttiym9eT2aA70gLXWqE FUtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Authentication-Results: mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Date: Mon, 19 Mar 2018 17:20:30 +0100 Message-ID: From: Takashi Iwai To: "kbuild test robot" Cc: "Ruslan Bilovol" , , , "Jorge" , "Pierre-Louis Bossart" , "Greg Kroah-Hartman" , Subject: Re: [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support In-Reply-To: <201803192103.TpMCRTC7%fengguang.wu@intel.com> References: <1521423963-24677-3-git-send-email-ruslan.bilovol@gmail.com> <201803192103.TpMCRTC7%fengguang.wu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1595328661372171880?= X-GMAIL-MSGID: =?utf-8?q?1595383672505019804?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, 19 Mar 2018 14:43:29 +0100, kbuild test robot wrote: > > Hi Ruslan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.16-rc6 next-20180316] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/ALSA-usb-audio-move-audioformat-quirks-to-quirks-c/20180319-205541 > config: i386-randconfig-x016-201811 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > Note: it may well be a FALSE warning. FWIW you are at least aware of it now. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings (new ones prefixed by >>): > > sound/usb/stream.c: In function 'snd_usb_parse_audio_interface': > >> sound/usb/stream.c:956:8: warning: 'fmt' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (snd_usb_parse_audio_format(chip, fp, format, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fmt, stream) < 0) { > ~~~~~~~~~~~~ Hm, this looks like a false-postive, although I see it on my local build, too. I'm not always a fan of unneeded initialization, but this time, we can be lazy and add a NULL initialization... thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support Date: Mon, 19 Mar 2018 17:20:30 +0100 Message-ID: References: <1521423963-24677-3-git-send-email-ruslan.bilovol@gmail.com> <201803192103.TpMCRTC7%fengguang.wu@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 372D22670A1 for ; Mon, 19 Mar 2018 17:20:31 +0100 (CET) In-Reply-To: <201803192103.TpMCRTC7%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: kbuild test robot Cc: alsa-devel@alsa-project.org, Greg Kroah-Hartman , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Jorge , Ruslan Bilovol , kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Mon, 19 Mar 2018 14:43:29 +0100, kbuild test robot wrote: > > Hi Ruslan, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.16-rc6 next-20180316] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/ALSA-usb-audio-move-audioformat-quirks-to-quirks-c/20180319-205541 > config: i386-randconfig-x016-201811 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > Note: it may well be a FALSE warning. FWIW you are at least aware of it now. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings (new ones prefixed by >>): > > sound/usb/stream.c: In function 'snd_usb_parse_audio_interface': > >> sound/usb/stream.c:956:8: warning: 'fmt' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (snd_usb_parse_audio_format(chip, fp, format, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > fmt, stream) < 0) { > ~~~~~~~~~~~~ Hm, this looks like a false-postive, although I see it on my local build, too. I'm not always a fan of unneeded initialization, but this time, we can be lazy and add a NULL initialization... thanks, Takashi