All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dana Goyette <danagoyette@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: ALC1150 broken on SuperMicro X10SAT
Date: Tue, 02 Sep 2014 07:27:39 +0200	[thread overview]
Message-ID: <s5h38cak2wk.wl-tiwai@suse.de> (raw)
In-Reply-To: <5405346E.1010502@gmail.com>

At Mon, 01 Sep 2014 20:07:26 -0700,
Dana Goyette wrote:
> 
> On 09/01/2014 06:17 AM, Takashi Iwai wrote:
> > What about the patch below?  It might be that only one of two changes
> > is needed.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > ---
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index d446ac3137b3..1ba22fb527c2 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -328,6 +328,7 @@ static void alc_auto_init_amp(struct hda_codec *codec, int type)
> >   		case 0x10ec0885:
> >   		case 0x10ec0887:
> >   		/*case 0x10ec0889:*/ /* this causes an SPDIF problem */
> > +		case 0x10ec0900:
> >   			alc889_coef_init(codec);
> >   			break;
> >   		case 0x10ec0888:
> > @@ -2350,6 +2351,7 @@ static int patch_alc882(struct hda_codec *codec)
> >   	switch (codec->vendor_id) {
> >   	case 0x10ec0882:
> >   	case 0x10ec0885:
> > +	case 0x10ec0900:
> >   		break;
> >   	default:
> >   		/* ALC883 and variants */
> >
> I've applied the patch, and that fixes it without having to specify a 
> model.  Thanks!
> 
> For reference, here's alsa-info after the patch:
> 
> http://www.alsa-project.org/db/?f=d3a135bd31671e545067821bbd2cacc9d8f6fff8

Thanks for a quick test.
FWIW, I applied the patch below to sound git tree now.


Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: hda - Fix COEF setups for ALC1150 codec

ALC1150 codec seems to need the COEF- and PLL-setups just like its
compatible ALC882 codec.  Some machines (e.g. SunMicro X10SAT) show
the problem like too low output volumes unless the COEF setup is
applied.

Reported-and-tested-by: Dana Goyette <danagoyette@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d446ac3137b3..1ba22fb527c2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -328,6 +328,7 @@ static void alc_auto_init_amp(struct hda_codec *codec, int type)
 		case 0x10ec0885:
 		case 0x10ec0887:
 		/*case 0x10ec0889:*/ /* this causes an SPDIF problem */
+		case 0x10ec0900:
 			alc889_coef_init(codec);
 			break;
 		case 0x10ec0888:
@@ -2350,6 +2351,7 @@ static int patch_alc882(struct hda_codec *codec)
 	switch (codec->vendor_id) {
 	case 0x10ec0882:
 	case 0x10ec0885:
+	case 0x10ec0900:
 		break;
 	default:
 		/* ALC883 and variants */
-- 
2.1.0

  reply	other threads:[~2014-09-02  5:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 20:20 ALC1150 broken on SuperMicro X10SAT Dana Goyette
2014-09-01 13:17 ` Takashi Iwai
2014-09-02  3:07   ` Dana Goyette
2014-09-02  5:27     ` Takashi Iwai [this message]
2014-09-02  5:27     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h38cak2wk.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=danagoyette@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.