Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

From: Takashi Iwai <tiwai@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Daniel Mack <zonque@gmail.com>,
	Christof Meerwald <cmeerw@cmeerw.org>,
	"Artem S. Tashkinov" <t.artem@lycos.com>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website
Date: Thu, 08 Nov 2012 16:58:17 +0100	[thread overview]
Message-ID: <s5h390k3x46.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1211081054340.1280-100000@iolanthe.rowland.org>

At Thu, 8 Nov 2012 10:55:50 -0500 (EST),
Alan Stern wrote:
> 
> On Thu, 8 Nov 2012, Takashi Iwai wrote:
> 
> > At Thu, 08 Nov 2012 08:31:35 +0100,
> > Daniel Mack wrote:
> > (snip)
> > > >> We can't simply stop both endpoints in the prepare callback.
> > > > 
> > > > The new function doesn't stop the stream by itself but it just syncs
> > > > if the stream is being stopped beforehand.  So, it's safe to call it
> > > > there.
> > > > 
> > > > Maybe the name was confusing.  It should have been like
> > > > snd_usb_endpoint_sync_pending_stop() or such.
> > > 
> > > Ah, right. I was errornously looking closer to Alan's patch but then
> > > replied to yours. Alright then - thanks for explaining :)
> > 
> > OK, thanks for checking.
> > 
> > FWIW, below is the patch I applied now to for-linus branch.
> > Renamed the function, added the comment and put NULL check to the
> > function to simplify.
> 
> Thanks for fixing this.  Is your patch marked for -stable?

Yes.  I'm going to send a pull request to Linus tomorrow.

> I have submitted a patch for ehci-hcd, so we should be all set.

OK, thanks!

Takashi