From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32178C433DB for ; Mon, 25 Jan 2021 16:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF25D229C4 for ; Mon, 25 Jan 2021 16:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730788AbhAYQqe (ORCPT ); Mon, 25 Jan 2021 11:46:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:48808 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730796AbhAYQeV (ORCPT ); Mon, 25 Jan 2021 11:34:21 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C9F7ACC6; Mon, 25 Jan 2021 15:18:33 +0000 (UTC) Date: Mon, 25 Jan 2021 16:18:33 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Sameer Pujar , Peter Geis , Nicolas Chauvet , Takashi Iwai , Matt Merhar , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] Clock and reset improvements for Tegra ALSA drivers In-Reply-To: <20210120003154.26749-1-digetx@gmail.com> References: <20210120003154.26749-1-digetx@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, 20 Jan 2021 01:31:48 +0100, Dmitry Osipenko wrote: > > This series improves the handling of clock and reset controls of > NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling > resets properly, which needs to be fixed in order to unblock other patches > related to fixes of the reset controller driver since HDA/AHUB are bound > to fail once reset controller driver will be corrected. In particular ALSA > drivers are relying on implicit de-assertion of resets which is done by the > tegra-clk driver. It's not the business of the clk driver to touch resets > and we need to fix this because it breaks reset/clk programming sequences > of other Tegra drivers. > > Changelog: > > v3: - Reworked "hda/tegra: Reset hardware" and "ahub: Reset hardware properly" > patches, they now use usleep + reset_deassert() instead of reset_reset(). > Suggested by Thierry Reding. > > - Added new patch "hda/tegra: Remove unnecessary null-check from > hda_tegra_runtime_resume()". Suggested by Thierry Reding. > > - Replaced "ahub: Reset hardware properly" patch with "ahub: Add missing > resets". Suggested by Thierry Reding. > > - Slightly improved commit messages. > > - Added acks from Thierry Reding. > > v2: - Added regcache_sync() to the "ahub: Reset hardware properly" patch, > which was missed by accident in v1. > > - Corrected typo in the format of the error message in "ahub: Use > of_reset_control_array_get_exclusive()" patch by s/%p/%pe/. > > Dmitry Osipenko (6): > ALSA: hda/tegra: Use clk_bulk helpers > ALSA: hda/tegra: Reset hardware > ALSA: hda/tegra: Remove unnecessary null-check from > hda_tegra_runtime_resume() > ASoC: tegra: ahub: Add missing resets > ASoC: tegra: ahub: Use clk_bulk helpers > ASoC: tegra: ahub: Reset hardware properly Mark, a half of the series are for ASoC. Would you take those three, or take the full patches or let me merge through my tree? thanks, Takashi > > sound/pci/hda/hda_tegra.c | 90 ++++++++++++---------------------- > sound/soc/tegra/tegra30_ahub.c | 64 ++++++++++++++---------- > sound/soc/tegra/tegra30_ahub.h | 5 +- > 3 files changed, 72 insertions(+), 87 deletions(-) > > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0AFC433DB for ; Mon, 25 Jan 2021 15:19:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AC9A22C9E for ; Mon, 25 Jan 2021 15:19:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AC9A22C9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2ECAF1795; Mon, 25 Jan 2021 16:18:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2ECAF1795 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611587969; bh=1f16T0ij2CGN1L/buj9GrvieiOWNkOsbjbA6yfwgsiQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gU11ohdW/rjeN5k3BfzO/pDPsAh2wYUj1ifAg8FbdPlGJyUseoK2FkCi9+KjMVqfl Cro6R3qt8/IUfjpWBqtRc2mxoaRpsQep2H6RKW4MofrU64pF1fkSEQ3WHjIIo2Ns6R AXQZ9oKmkN0HtYxgbeOjmhI6QOJr423VJtPeNiOA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8D67CF80218; Mon, 25 Jan 2021 16:18:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4909BF80259; Mon, 25 Jan 2021 16:18:37 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 704BBF80130 for ; Mon, 25 Jan 2021 16:18:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 704BBF80130 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6C9F7ACC6; Mon, 25 Jan 2021 15:18:33 +0000 (UTC) Date: Mon, 25 Jan 2021 16:18:33 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Subject: Re: [PATCH v3 0/6] Clock and reset improvements for Tegra ALSA drivers In-Reply-To: <20210120003154.26749-1-digetx@gmail.com> References: <20210120003154.26749-1-digetx@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Nicolas Chauvet , linux-kernel@vger.kernel.org, Sameer Pujar , Takashi Iwai , Jonathan Hunter , Thierry Reding , Matt Merhar , Peter Geis , linux-tegra@vger.kernel.org, Dmitry Osipenko X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021 01:31:48 +0100, Dmitry Osipenko wrote: > > This series improves the handling of clock and reset controls of > NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling > resets properly, which needs to be fixed in order to unblock other patches > related to fixes of the reset controller driver since HDA/AHUB are bound > to fail once reset controller driver will be corrected. In particular ALSA > drivers are relying on implicit de-assertion of resets which is done by the > tegra-clk driver. It's not the business of the clk driver to touch resets > and we need to fix this because it breaks reset/clk programming sequences > of other Tegra drivers. > > Changelog: > > v3: - Reworked "hda/tegra: Reset hardware" and "ahub: Reset hardware properly" > patches, they now use usleep + reset_deassert() instead of reset_reset(). > Suggested by Thierry Reding. > > - Added new patch "hda/tegra: Remove unnecessary null-check from > hda_tegra_runtime_resume()". Suggested by Thierry Reding. > > - Replaced "ahub: Reset hardware properly" patch with "ahub: Add missing > resets". Suggested by Thierry Reding. > > - Slightly improved commit messages. > > - Added acks from Thierry Reding. > > v2: - Added regcache_sync() to the "ahub: Reset hardware properly" patch, > which was missed by accident in v1. > > - Corrected typo in the format of the error message in "ahub: Use > of_reset_control_array_get_exclusive()" patch by s/%p/%pe/. > > Dmitry Osipenko (6): > ALSA: hda/tegra: Use clk_bulk helpers > ALSA: hda/tegra: Reset hardware > ALSA: hda/tegra: Remove unnecessary null-check from > hda_tegra_runtime_resume() > ASoC: tegra: ahub: Add missing resets > ASoC: tegra: ahub: Use clk_bulk helpers > ASoC: tegra: ahub: Reset hardware properly Mark, a half of the series are for ASoC. Would you take those three, or take the full patches or let me merge through my tree? thanks, Takashi > > sound/pci/hda/hda_tegra.c | 90 ++++++++++++---------------------- > sound/soc/tegra/tegra30_ahub.c | 64 ++++++++++++++---------- > sound/soc/tegra/tegra30_ahub.h | 5 +- > 3 files changed, 72 insertions(+), 87 deletions(-) > > -- > 2.29.2 >