All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: changjoon.lee@lge.com
Cc: alsa-devel@alsa-project.org, linux@endlessm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] Documentation update
Date: Thu, 14 May 2020 11:22:46 +0200	[thread overview]
Message-ID: <s5h4ksiswex.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5h5zcyswhw.wl-tiwai@suse.de>

On Thu, 14 May 2020 11:20:59 +0200,
Takashi Iwai wrote:
> 
> On Thu, 14 May 2020 11:07:15 +0200,
> changjoon.lee@lge.com wrote:
> > 
> > From: ChangJoon Lee <changjoon.lee@lge.com>
> > 
> > Hi, ALSA Teams,
> > 
> > This is documentation update purpose patch.
> > This patch does NOT alter any of operations.
> > 
> > This patch allows an application engineer to understand why they received negative return
> > such as -EIO, -EBADFD, -ENOSYS, -ESTRPIPE and etc which are not fully documented on documentation site.
> > 
> > This patch also exposes Expected Status of PCM based on bad_pcm_state() with P_STATE to help engineer to understand API behavior to the documentation site.
> > 
> > TODO :
> > We may need improve consistency of return value especially for snd_pcm_hw_params_current().
> > It returns -EBADFD when PCM is not setup while other API returns -EIO in this case.
> 
> Could you put those explanations rather into the patch description,
> not (only) in the cover letter?

Also, when you resubmit with some changes, it's helpful to add a
prefix like "v2" to the subject line, e.g.
  [PATCH v2] Fix something ....

Additionally it's often helpful to mention concisely what you changed
from the previous submission.


thanks,

Takashi

  reply	other threads:[~2020-05-14  9:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  9:07 [PATCH 0/1] Documentation update changjoon.lee
2020-05-14  9:07 ` changjoon.lee
2020-05-14  9:07 ` [PATCH 1/1] Updated negative return values for documentation update changjoon.lee
2020-05-14  9:07   ` changjoon.lee
2020-05-14  9:20 ` [PATCH 0/1] Documentation update Takashi Iwai
2020-05-14  9:22   ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-12  9:05 changjoon.lee
2020-05-12  9:05 ` changjoon.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4ksiswex.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=changjoon.lee@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.