From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 0/5] Fix poll error returns Date: Mon, 09 May 2016 14:13:55 +0200 Message-ID: References: <1462370351-15388-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7AE002658B1 for ; Mon, 9 May 2016 14:13:59 +0200 (CEST) In-Reply-To: <1462370351-15388-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Charles Keepax Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, 04 May 2016 15:59:06 +0200, Charles Keepax wrote: > > We return negative values from the file_operations poll callback > in a few places, this callback returns an unsigned int and is > expected to only return the poll specific flags. This series > fixes up these issues and makes a couple of small tidy ups to the > code around the edges of those functions. > > I noticed this issue whilst doing some additional testing on my > propagation of compressed stream error series, but I decided to > push these up separately as it is worth getting the fixes in > now and not tying them up with that patch chain which is taking > longer to get merged. Also I included the first patch of that > chain (Replace complex if statement with switch) because it is a > trivial tidy up and might as well get merged now as well. Patches 2, 3 and 4 miss Vinod's ack. Vinod, are you OK with them? thanks, Takashi > > Thanks, > Charles > > Charles Keepax (5): > ALSA: pcm: Fix poll error return codes > ALSA: compress: Use snd_compr_get_poll on error path > ALSA: compress: Remove pointless NULL check > ALSA: compress: Fix poll error return codes > ALSA: compress: Replace complex if statement with switch > > sound/core/compress_offload.c | 25 ++++++++++++------------- > sound/core/pcm_native.c | 4 ++-- > 2 files changed, 14 insertions(+), 15 deletions(-) > > -- > 2.1.4 > >