From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755310Ab2HINcW (ORCPT ); Thu, 9 Aug 2012 09:32:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57952 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489Ab2HINcV (ORCPT ); Thu, 9 Aug 2012 09:32:21 -0400 Date: Thu, 09 Aug 2012 15:32:20 +0200 Message-ID: From: Takashi Iwai To: David Henningsson Cc: Thierry Reding , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() In-Reply-To: <5023BAA0.1080304@canonical.com> References: <1344494723-6827-1-git-send-email-thierry.reding@avionic-design.de> <20120809070813.GA6979@avionic-0098.mockup.avionic-design.de> <20120809073642.GA24695@avionic-0098.mockup.avionic-design.de> <20120809080713.GC24808@avionic-0098.mockup.avionic-design.de> <20120809103430.GA1560@avionic-0098.mockup.avionic-design.de> <5023BAA0.1080304@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 09 Aug 2012 15:26:56 +0200, David Henningsson wrote: > > On 08/09/2012 03:11 PM, Takashi Iwai wrote: > > > @@ -3187,13 +3217,16 @@ static int __devinit azx_probe(struct pci_dev *pci, > > if (patch[dev] && *patch[dev]) { > > snd_printk(KERN_ERR SFX "Applying patch firmware '%s'\n", > > patch[dev]); > > - err = request_firmware(&chip->fw, patch[dev], &pci->dev); > > + err = request_firmware_nowait(THIS_MODULE, true, patch[dev], > > + &pci->dev, GFP_KERNEL, card, > > + azx_firmware_cb); > > if (err < 0) > > goto out_free; > > + chip->probe_deferred = 1; > > I might be out on deep water here, but isn't this racy? Or is > azx_firmware_cb somehow guaranteed not to execute before this function > has exited? chip->probe_deferred is used only at the line below. So basically it's not necessarily to be recorded in chip, but could be a local bool variable in azx_probe(). It remains in chip just because of my older patch had it. > > > } > > #endif /* CONFIG_SND_HDA_PATCH_LOADER */ > > > > - if (!chip->disabled) { > > + if (!chip->disabled && !chip->probe_deferred) { Here it's checked. Takashi > > err = azx_probe_continue(chip); > > if (err < 0) > > goto out_free; > > > > > > -- > David Henningsson, Canonical Ltd. > https://launchpad.net/~diwic > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() Date: Thu, 09 Aug 2012 15:32:20 +0200 Message-ID: References: <1344494723-6827-1-git-send-email-thierry.reding@avionic-design.de> <20120809070813.GA6979@avionic-0098.mockup.avionic-design.de> <20120809073642.GA24695@avionic-0098.mockup.avionic-design.de> <20120809080713.GC24808@avionic-0098.mockup.avionic-design.de> <20120809103430.GA1560@avionic-0098.mockup.avionic-design.de> <5023BAA0.1080304@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 47FE526633E for ; Thu, 9 Aug 2012 15:02:34 +0200 (CEST) In-Reply-To: <5023BAA0.1080304@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: alsa-devel@alsa-project.org, Thierry Reding , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Thu, 09 Aug 2012 15:26:56 +0200, David Henningsson wrote: > > On 08/09/2012 03:11 PM, Takashi Iwai wrote: > > > @@ -3187,13 +3217,16 @@ static int __devinit azx_probe(struct pci_dev *pci, > > if (patch[dev] && *patch[dev]) { > > snd_printk(KERN_ERR SFX "Applying patch firmware '%s'\n", > > patch[dev]); > > - err = request_firmware(&chip->fw, patch[dev], &pci->dev); > > + err = request_firmware_nowait(THIS_MODULE, true, patch[dev], > > + &pci->dev, GFP_KERNEL, card, > > + azx_firmware_cb); > > if (err < 0) > > goto out_free; > > + chip->probe_deferred = 1; > > I might be out on deep water here, but isn't this racy? Or is > azx_firmware_cb somehow guaranteed not to execute before this function > has exited? chip->probe_deferred is used only at the line below. So basically it's not necessarily to be recorded in chip, but could be a local bool variable in azx_probe(). It remains in chip just because of my older patch had it. > > > } > > #endif /* CONFIG_SND_HDA_PATCH_LOADER */ > > > > - if (!chip->disabled) { > > + if (!chip->disabled && !chip->probe_deferred) { Here it's checked. Takashi > > err = azx_probe_continue(chip); > > if (err < 0) > > goto out_free; > > > > > > -- > David Henningsson, Canonical Ltd. > https://launchpad.net/~diwic >