Re: [PATCH 1/3] Unify M-Audio Fast Track Ultra and Ebox-44 mixer quirks.

[Takashi Iwai <tiwai@suse.de>]

At Mon, 23 Apr 2012 11:57:32 +0200,
Felix Homann wrote:
> 
> 2012/4/23 Takashi Iwai <tiwai@suse.de>:
> >> Allows for specifying a TLV callback.
> >
> > Too little information as the patch changelog.
> > Please be more specific what and how is implemented there.
> 
> OK.
> 
> > This should be snd_create_std_mono_ctl(), no?
> 
> Yes, I wasn't aware that I had only fixed this in a later commit.
> 
> > Each patch should be able to be built properly.  Otherwise it breaks
> > the bisection.
> 
> Yes, that makes sense.
> 
> 
> >> +/* Create a volume control for FTU devices*/
> >> +static int snd_maudio_ftu_create_volume_ctls(struct usb_mixer_interface *mixer)
> >>  {
> >>       char name[64];
> >> -     int in, out, err;
> >> +     unsigned int id, control, cmask;
> >> +     int in, out, err, val_type;
> >> +
> >> +     id = 5;
> >> +     val_type = USB_MIXER_S16;
> >
> > Give const.  I don't mind use such styles instead of define or
> > hard-coded in the function calls, but then it should be marked as
> > const properly.
> 
> I don't mind to use a define here. Just tell me what you prefer.

Well, I don't mind either way.  The point is that you should add const
if you keep that style.


> I'll prepare a coreccted patch set soon.

Thanks!


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel