From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE03C43603 for ; Tue, 10 Dec 2019 15:59:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01BC92053B for ; Tue, 10 Dec 2019 15:59:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jYzobbCa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01BC92053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E4321668; Tue, 10 Dec 2019 16:58:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E4321668 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575993573; bh=8vcSN6qDt2cLCO12AuNMZEse6quXRSblL/r3nA/dWxk=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jYzobbCaNrHcOdrYoxxYhy89/riU7Nx99G/eLAjb3hA9H39/BgUXK44vPwASvyfVH AyRVA6URFF0slGYej1ssUPgKmn8w0qivLFLUol0bcc8ym2qD84ly7AolKw4UiA5Q6W AnMyzAZI8dj0GjtN9S2iIz3x6uzYkdS9a6EdiwBw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1F945F800B4; Tue, 10 Dec 2019 16:58:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BD8BBF8020C; Tue, 10 Dec 2019 16:58:41 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 827E5F800B4 for ; Tue, 10 Dec 2019 16:58:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 827E5F800B4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6608EACEF; Tue, 10 Dec 2019 15:58:37 +0000 (UTC) Date: Tue, 10 Dec 2019 16:58:37 +0100 Message-ID: From: Takashi Iwai To: Takashi Sakamoto In-Reply-To: <20191210154927.GA31637@workstation> References: <20191210061145.24641-1-tiwai@suse.de> <20191210061145.24641-6-tiwai@suse.de> <20191210154927.GA31637@workstation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH 05/23] ALSA: firewire: Drop superfluous ioctl PCM ops X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 10 Dec 2019 16:49:28 +0100, Takashi Sakamoto wrote: > > Hi, > > On Tue, Dec 10, 2019 at 07:11:27AM +0100, Takashi Iwai wrote: > > Signed-off-by: Takashi Iwai > > --- > > sound/firewire/bebob/bebob_pcm.c | 2 -- > > sound/firewire/dice/dice-pcm.c | 2 -- > > sound/firewire/digi00x/digi00x-pcm.c | 2 -- > > sound/firewire/fireface/ff-pcm.c | 2 -- > > sound/firewire/fireworks/fireworks_pcm.c | 2 -- > > sound/firewire/isight.c | 1 - > > sound/firewire/motu/motu-pcm.c | 2 -- > > sound/firewire/oxfw/oxfw-pcm.c | 2 -- > > sound/firewire/tascam/tascam-pcm.c | 2 -- > > 9 files changed, 17 deletions(-) > > I understand that this patch is based on the below commit: > * fc033cbf6fb7("ALSA: pcm: Allow NULL ioctl ops")[1] > > All of the changes are fine to me. > > Acked-by: Takashi Sakamoto > > [1] https://mailman.alsa-project.org/pipermail/alsa-devel/2019-November/158692.html Thanks. It's good idea to put the background information. I'll add it to the changelog. Actually I seem to have forgotten to fill the changelog text in this commit. Below is the revised patch to be committed. Takashi -- 8< -- Subject: [PATCH] ALSA: firewire: Drop superfluous ioctl PCM ops All the PCM ioctl ops of ALSA FireWire drivers do nothing but calling the default handler. Now PCM core accepts NULL as the default ioctl ops(*), so let's drop altogether. (*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops") Acked-by: Takashi Sakamoto Link: https://lore.kernel.org/r/20191210061145.24641-6-tiwai@suse.de Signed-off-by: Takashi Iwai _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel