From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751400AbdJEGWp (ORCPT ); Thu, 5 Oct 2017 02:22:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:40956 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751268AbdJEGWo (ORCPT ); Thu, 5 Oct 2017 02:22:44 -0400 Date: Thu, 05 Oct 2017 08:22:40 +0200 Message-ID: From: Takashi Iwai To: "Kees Cook" Cc: , , "Bhumika Goyal" , "Mark Brown" , "Thomas Gleixner" , "Jaroslav Kysela" Subject: Re: [PATCH] ALSA: sh: aica: Convert timers to use timer_setup() In-Reply-To: <20171005005336.GA23796@beast> References: <20171005005336.GA23796@beast> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Oct 2017 02:53:36 +0200, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. This requires adding a pointer to > hold the timer's target substream, as there won't be a way to pass this in > the future. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Bhumika Goyal > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-alone. The conversions look straightforward, so I'm going to apply it (and other two you posted). But now I wonder why only three were chosen. Will you keep working on the rest usages in sound/*, or would you expect us doing the rest? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: sh: aica: Convert timers to use timer_setup() Date: Thu, 05 Oct 2017 08:22:40 +0200 Message-ID: References: <20171005005336.GA23796@beast> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20171005005336.GA23796@beast> Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Bhumika Goyal , Mark Brown , Thomas Gleixner , Jaroslav Kysela List-Id: alsa-devel@alsa-project.org On Thu, 05 Oct 2017 02:53:36 +0200, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. This requires adding a pointer to > hold the timer's target substream, as there won't be a way to pass this in > the future. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Bhumika Goyal > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Cc: Thomas Gleixner > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-alone. The conversions look straightforward, so I'm going to apply it (and other two you posted). But now I wonder why only three were chosen. Will you keep working on the rest usages in sound/*, or would you expect us doing the rest? thanks, Takashi