From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753367AbdHXPmP (ORCPT ); Thu, 24 Aug 2017 11:42:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:56190 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752984AbdHXPmN (ORCPT ); Thu, 24 Aug 2017 11:42:13 -0400 Date: Thu, 24 Aug 2017 17:42:11 +0200 Message-ID: From: Takashi Iwai To: Tom Rini Cc: Linus Torvalds , Mark Brown , alsa-devel@alsa-project.org, Liam Girdwood , Andy Shevchenko , Bard Liao , Oder Chiou , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs In-Reply-To: <20170824144152.GC17193@bill-the-cat> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503498573.25945.69.camel@linux.intel.com> <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat> <20170824144152.GC17193@bill-the-cat> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2017 16:41:52 +0200, Tom Rini wrote: > > On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote: > > On Thu, 24 Aug 2017 16:28:29 +0200, > > Takashi Iwai wrote: > > > > > > On Thu, 24 Aug 2017 02:05:25 +0200, > > > Tom Rini wrote: > > > > > > > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote: > > > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote: > > > > > > > > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote: > > > > > > > Not all devices with ACPI and this combination of sound devices will > > > > > > > have the required information provided via ACPI.  Reintroduce the I2C > > > > > > > device ID to restore sound functionality on on the Chromebook 'Samus' > > > > > > > model. > > > > > > > > > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus' > > > > > > > that's not running ChromeOS).  My fault for getting out of the habit > > > > > > > of > > > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not > > > > > > > 100% sure if this fix is correct for all cases as I'm only able to > > > > > > > test > > > > > > > my hardware here, and this does fix my laptop. > > > > > > > > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data > > > > > > in the module sources") does not fix your issue? > > > > > > > > > > As that's not in master yet I can't tell. Can you give me a pointer to > > > > > somewhere? Thanks! > > > > > > > > OK, my bad, it has a different hash upstream, > > > > BTW, the hash above is correct. It's in Mark's asoc tree (and in > > linux-next). You might have cherry-picked a wrong one, I suppose? > > Alright, I read-things to quickly, and to be clear: > (a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in > Linus' tree (I confused this with a different commit) and _is_ in Mark's > ASoC for-next branch currently. > (b) Applying just that patch on top of Linus' tree _does_ fix my > regression (an Oops and non-functional audio) with audio and now sound > works well, as expected. > > Can we please get that as a fix for this release? Thanks! OK, so the fix for 4.13 would be either to cherry-pick this commit, or just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid fix (and remove again in 4.14). The former is cleaner, but it's bigger, while the latter is a safer oneliner at the late RC stage. I leave the decision to Mark. Takashi