From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 0/4] ALSA: hda beep clean up Date: Wed, 04 Jul 2012 07:16:59 +0200 Message-ID: References: <1341331397-21182-1-git-send-email-tiwai@suse.de> <4FF31E7B.8030906@perex.cz> <4FF34FA9.10806@perex.cz> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 92D5F104317 for ; Wed, 4 Jul 2012 07:17:00 +0200 (CEST) In-Reply-To: <4FF34FA9.10806@perex.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jaroslav Kysela Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 03 Jul 2012 22:01:45 +0200, Jaroslav Kysela wrote: > > Date 3.7.2012 18:31, Jaroslav Kysela wrote: > > Date 3.7.2012 18:03, Takashi Iwai wrote: > >> Hi, > >> > >> this is a series of small cleanups of HD-audio beep code. > >> Since the keyboard driver already handles the simultaneous outputs > >> from the multiple input beep instances, there is no merit to have > >> beep_mode=2 option to switch the beep input device. > > > > Acked-by: Jaroslav Kysela > > While I acked this, I vaguely remember now, that the event duplication > (simultaneous outputs) caused some issues on some Lenovo notebooks. > > When the pcspkr and HDA beep generator is connected to the same output > (integrated speakers), it may cause some issues (bad beep quality - > frequency etc.). > > I looked to the input code, and the kd_mksound() calls > input_handler_for_each_handle(), thus the event is duplicated to all > beep generators, right? Right. > The beep_mode=2 was introduced to let users to help with this issue with > a comfortable way. Not really. At the time this was introduced, the keyboard driver took only a single input handle exclusively, namely only the last registered one. Thus playing on both had never happened until recently. Takashi