All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Chase Douglas <chase.douglas@canonical.com>,
	linux-input@vger.kernel.org, xorg-devel@lists.x.org,
	Chris Bagwell <chris@cnpbagwell.com>,
	Andy Whitcroft <apw@canonical.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	linux-kernel@vger.kernel.org,
	Peter Hutterer <peter.hutterer@who-t.net>,
	Duncan McGreggor <duncan.mcgreggor@canonical.com>
Subject: Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support
Date: Fri, 08 Oct 2010 21:31:30 +0200	[thread overview]
Message-ID: <s5h62xc4h2l.wl%tiwai@suse.de> (raw)
In-Reply-To: <201010081104.01527.dmitry.torokhov@gmail.com>

At Fri, 8 Oct 2010 11:04:01 -0700,
Dmitry Torokhov wrote:
> 
> On Friday, October 08, 2010 10:15:35 am Chase Douglas wrote:
> > On Fri, 2010-10-08 at 18:37 +0200, Takashi Iwai wrote:
> > > At Fri,  8 Oct 2010 10:57:57 -0400,
> > > 
> > > Chase Douglas wrote:
> > > > 
> > > >
> > > > Tobyn Bertram reverse engineered the multitouch protocol for Synaptics
> > > > devices. I've been able to take his work and produce a series of
> > > > commits to enable MT and multifinger (MF) support.
> > > >
> > > > 
> > > >
> > > > Unfortunately, there's a tricky issue with some Synaptics touchpads
> > > > that have integrated buttons. For example, the left and right buttons
> > > > on the touchpad of my Dell Mini 1012 consist of the lower ~20% of the
> > > > touchpad surface. The touchpad physically clicks under these areas.
> > > >
> > > > 
> > > >
> > > > The X synaptics input module now has a parameter to disable touches
> > > > occuring over the button area, but this solution still doesn't work
> > > > perfectly. If you click a button and drag with another finger near the
> > > > clicking finger, the touchpad gets confused.
> > > >
> > > > 
> > > >
> > > > Now that we have full MT support, we can try to handle this scenario
> > > > better. What I've found to work best is to make touches vanish if they
> > > > occur over the button area of the trackpad while any button is held.
> > > > This works in conjunction with the X synaptics driver to disable
> > > > single touch control over the button area. With full MT support, the
> > > > touchpad doesn't seem to get confused when a click and drag occurs
> > > > with two fingers close to each other, and it enables MT gestures and
> > > > MF support across the entire trackpad when no buttons are held.
> > > >
> > > > 
> > > >
> > > > The first question is whether this seems appropriate to others, or if
> > > > some other method would work better. Secondarily, should the solution
> > > > occur in the kernel, like I have in the third patch of this series, or
> > > > should it occur in the X input module? Although we don't have this
> > > > information today, we may be able to query the touchpad in the future
> > > > to know the area of the integrated buttons. If that were possible,
> > > > would the recommended location for the hack change?
> > >
> > > 
> > >
> > > Great!  Finally someone found it out!
> > > I found this and made a series of patches in 4 months ago.  Since
> > > then, Novell legal prohibited me to send the patches to the upstream
> > > due to "possible patent infringing".  Now you cracked out.  Yay.
> > >
> > > 
> > >
> > > FWIW, my corresponding patch is below.  It really looks similar in the
> > > end ;)  I added a kconfig just to be safer.
> > >
> > > 
> > >
> > > Regarding the "clickpad" support: in my case, I implemented almost
> > > everything about it in xorg driver.  I'm going to submit xorg
> > > patches.
> > 
> > So I'm confused. I was working off of source code posted to:
> > 
> > https://bugs.launchpad.net/utouch/+bug/633225
> > 
> > I was under the impression that someone else had reverse engineered the
> > protocol and written patches. But the code is exactly the same as what
> > you've posted here. If you're the originator of the work, and my patch
> > is accepted, I think we'll need your SOB on it.
> 
> Comment #6 is quite clear on this matter:
> 
> > Takashi Iwai from OpenSuse has done quite a bit of work for the Synaptics
> > Clickpad including some experimental multitouch support, his repo is here:
> > http://download.opensuse.org/repositories/home:/tiwai:/clickpad:/openSUSE_
> > 11.3/openSUSE_11.3/src/
> > 
> > I have played around with the synaptics.c code in the kernel to add
> > multitouch events (ABS_MT_POSITION_X, ABS_MT_POSITION_Y, ABS_MT_PRESSURE)
> > using Takashi's work as a model.
> 
> So I do believe we need to have Takashi's SOB at the very least and maybe
> credit him as the author of the patches.

I sent my original one, so this should suffice, right?


thanks,

Takashi

  reply	other threads:[~2010-10-08 19:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 14:57 [PATCH 0/3] Input: synaptics - multitouch and multifinger support Chase Douglas
2010-10-08 14:57 ` [PATCH 1/3] Input: synaptics - add multitouch support Chase Douglas
2010-10-08 14:57   ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chase Douglas
2010-10-08 14:58     ` [PATCH 3/3] Input: synaptics - remove touches over button click area Chase Douglas
2010-10-10 15:58       ` Chris Bagwell
2010-10-11 16:24       ` Chris Bagwell
2010-10-11 16:24         ` Chris Bagwell
2010-10-11 17:10         ` Takashi Iwai
2010-10-11 17:10           ` Takashi Iwai
2010-10-11 17:30           ` Dmitry Torokhov
2010-10-11 17:30             ` Dmitry Torokhov
2010-10-11 17:40             ` Takashi Iwai
2010-10-11 17:46           ` Chris Bagwell
2010-10-11 17:46             ` Chris Bagwell
2010-10-11 17:54             ` Henrik Rydberg
2010-10-11 18:29             ` Takashi Iwai
2010-10-11 18:29               ` Takashi Iwai
2010-10-10 15:44     ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chris Bagwell
2010-10-10 15:37   ` [PATCH 1/3] Input: synaptics - add multitouch support Chris Bagwell
2010-10-10 15:41   ` Chris Bagwell
2010-10-08 16:37 ` [PATCH 0/3] Input: synaptics - multitouch and multifinger support Takashi Iwai
2010-10-08 16:38   ` Takashi Iwai
2010-10-08 17:48     ` Takashi Iwai
2010-10-08 17:15   ` Chase Douglas
2010-10-08 17:46     ` Takashi Iwai
2010-10-08 18:04     ` Dmitry Torokhov
2010-10-08 19:31       ` Takashi Iwai [this message]
2010-10-10 21:04         ` Dmitry Torokhov
2010-10-11  7:35           ` Takashi Iwai
2010-10-11  7:48             ` Henrik Rydberg
2010-10-11  7:59               ` Takashi Iwai
2010-10-11 13:41               ` Chris Bagwell
2010-10-11 13:41                 ` Chris Bagwell
2010-10-11 14:01                 ` Takashi Iwai
2010-10-11 14:01                   ` Takashi Iwai
2010-10-11 14:24                   ` Henrik Rydberg
2010-10-11 14:49                     ` Takashi Iwai
2010-10-11 15:31                       ` Henrik Rydberg
2010-10-11 15:58                         ` Takashi Iwai
2010-10-10  7:49   ` Henrik Rydberg
2010-10-10 20:59     ` Dmitry Torokhov
2010-10-11  7:28       ` Takashi Iwai
2010-10-11  7:40         ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h62xc4h2l.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=apw@canonical.com \
    --cc=chase.douglas@canonical.com \
    --cc=chris@cnpbagwell.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=duncan.mcgreggor@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=rydberg@euromail.se \
    --cc=xorg-devel@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.