From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E176AC4338F for ; Fri, 13 Aug 2021 06:04:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F2796109E for ; Fri, 13 Aug 2021 06:04:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F2796109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0508718A0; Fri, 13 Aug 2021 08:04:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0508718A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628834694; bh=dJvDtyU7VS7zQfEA1POZ4qavldJlxDWog5Jx5nFn2Ls=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LPjvwrqTH2BLcouMqp8ipqHA5ed6r8Hw5D9Czdz0e46EoNmNCQF7fx8YEUInV9Vu0 TS5q9E0diwfR98rdAc0FnDKpc0X4cm3h7nsNwpIebYOXj7KdszOTTnn4CVX7+8Hr1Q 8BnSMHrTtcX2sXNJFW60XlXzdfWjnqFDYlfEhr0o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 947C7F8020D; Fri, 13 Aug 2021 08:04:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C053F802D2; Fri, 13 Aug 2021 08:04:02 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 13474F800E5 for ; Fri, 13 Aug 2021 08:03:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 13474F800E5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vpE3drXj"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="TIYaSpt7" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id F3B7522289; Fri, 13 Aug 2021 06:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628834632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jZDOegIlxdbZkg8N7zo2cwCahBOtWzugDRLGWu65XRk=; b=vpE3drXjTgXkDa7DllG591U9QY6lugSNSQqSt6pZNNu5jwW6ex6CrT4gATQWUzNGz98IY+ Ij//EhIwJ4/+ptf12DIdqRLKMoY+subbT3lifRHhs0R9AfYo0QEfShIMIK7gK8VWAMALVD V5cYX/lY4r6rIqtxaPrP/TkMrbNijWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628834632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jZDOegIlxdbZkg8N7zo2cwCahBOtWzugDRLGWu65XRk=; b=TIYaSpt75y4nZFurSkhrIj0q0E7TY9IcFyCZL8jjuVoRxE8u7BfUVwsFDcN1orGdO+OeTt 86IEIC5kV/OdtYAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id EC2FAA3B87; Fri, 13 Aug 2021 06:03:51 +0000 (UTC) Date: Fri, 13 Aug 2021 08:03:51 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH RFC v2 2/4] ALSA: pcm: Add SNDRV_PCM_INFO_EXPLICIT_SYNC flag In-Reply-To: <0a2debee-439d-ebb8-2832-039074194d75@linux.intel.com> References: <20210812113818.6479-1-tiwai@suse.de> <20210812113818.6479-3-tiwai@suse.de> <0a2debee-439d-ebb8-2832-039074194d75@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 12 Aug 2021 20:37:06 +0200, Pierre-Louis Bossart wrote: > > > Hi Takashi, > > > ALSA PCM core has an optimized way to communicate with user-space for > > its control and status data via mmap on the supported architectures > > like x86. Depending on the situation, however, we'd rather want to > > enforce user-space notifying the applptr or hwptr change explicitly > > via ioctl. For example, the upcoming non-contig and non-coherent > > buffer handling would need an explicit sync, and this needs to catch > > the applptr and hwptr changes. > > > > This patch adds the new PCM hardware info flag, > > SNDRV_PCM_INFO_EXPLICIT_SYNC. When this flag is set, PCM core > > disables both the control and the status mmap, which enforces > > user-space to update via SYNC_PTR ioctl. In that way, drivers can > > catch the applptr and hwptr update and apply the sync operation if > > needed. > > This looks like the same functionality as in the patch "ALSA: pcm: > conditionally avoid mmap of control data" that we submitted for the SPIB > support, no? Yes, quite similar. That's what I mentioned in the reply at that time. > I was about to resubmit a v2 based on my version (code was reviewed on > GitHub in https://github.com/thesofproject/linux/pull/3076). > > If it's the same solution, could this patch be applied first so we are > aligned regardless of the order in which memalloc and SPIB patches are > merged? The renaming is fine, and that was your idea that I implemented > anyways. > > I think there would be a need for a tag as well so that Mark's tree > compiles when the SOF driver uses this. Sure, I can merge this one with a slight more rewording. thanks, Takashi