From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D99C433DB for ; Thu, 25 Mar 2021 14:30:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 575F5619B6 for ; Thu, 25 Mar 2021 14:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbhCYOaU (ORCPT ); Thu, 25 Mar 2021 10:30:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:42188 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230281AbhCYOaE (ORCPT ); Thu, 25 Mar 2021 10:30:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74181ADAA; Thu, 25 Mar 2021 14:30:03 +0000 (UTC) Date: Thu, 25 Mar 2021 15:30:03 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: Takashi Iwai , Jaroslav Kysela , Pavel Skripkin , Chris Chiu , Mark Brown , Lars-Peter Clausen , Tom Yan , Joe Perches , "moderated list:SOUND" , open list Subject: Re: [PATCH v2 2/2] ALSA: usb-audio: Check connector value on resume In-Reply-To: References: <20210325121250.133009-1-kai.heng.feng@canonical.com> <20210325121250.133009-2-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Mar 2021 15:24:42 +0100, Kai-Heng Feng wrote: > > On Thu, Mar 25, 2021 at 9:55 PM Kai-Heng Feng > wrote: > > > > On Thu, Mar 25, 2021 at 9:41 PM Takashi Iwai wrote: > > > > > > On Thu, 25 Mar 2021 13:12:48 +0100, > > > Kai-Heng Feng wrote: > > > > > > > > Rear Mic on Lenovo P620 cannot record after S3, despite that there's no > > > > error and the other two functions of the USB audio, Line In and Line > > > > Out, work just fine. > > > > > > > > The mic starts to work again after running userspace app like "alsactl > > > > store". Following the lead, the evidence shows that as soon as connector > > > > status is queried, the mic can work again. > > > > > > > > So also check connector value on resume to "wake up" the USB audio to > > > > make it functional. > > > > > > > > This can be device specific, however I think this generic approach may > > > > benefit more than one device. > > > > > > > > While at it, also remove reset-resume path to consolidate mixer resume > > > > path. > > > > > > > > Signed-off-by: Kai-Heng Feng > > > > --- > > > > v2: > > > > - Remove reset-resume. > > > > - Fold the connector checking to the mixer resume callback. > > > > > > That's not what I meant exactly... I meant to put both into the > > > single resume callback, but handle each part conditionally depending > > > on reset_resume argument. > > > > OK, I get what you mean now. > > > > > > > > But this turned out to need more changes in mixer_quirks.c > > > unnecessarily. Maybe adding the two resume functions is a better > > > approach in the end, but not for the specific connection thing but > > > generically both resume and reset_resume callbacks. Something like > > > below. > > > > This approach looks good. Let me send another one. > > Actually, it works really well and I don't I think I should send the > code you wrote. > Is it possible to push your version with my commit log, and with my tested tag? > > Tested-by: Kai-Heng Feng Heh, I'm too lazy to write up the whole commit. Could you just fold into yours and submit a v3 series? I don't mind who is credited as the author, just put me as Suggested-by or such, if any. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D325CC433E0 for ; Thu, 25 Mar 2021 14:31:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FE9B61A25 for ; Thu, 25 Mar 2021 14:31:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FE9B61A25 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 762311657; Thu, 25 Mar 2021 15:30:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 762311657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1616682681; bh=H3k58abzJArCmcPs9C+gGOHAgo+wjaEHlnKY258j1vk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AiowMGTAV+eDrSMB1cLBhEm10Q7KT6tlwfyUa5G3uIJXxj5xCNICTitHeJw6nNsS6 bNpjlN7DHLDgJLCCm30J04uvOTLCDPwAWcOZultT6xuQ60ZtQ/4jX9HAYyvPwiF6OU 4yUvnOaBATEPs7SRvUV3eVSVpWauZD3AJ50vvf8w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C2831F80257; Thu, 25 Mar 2021 15:30:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2EAC2F8025F; Thu, 25 Mar 2021 15:30:20 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 947A1F80103 for ; Thu, 25 Mar 2021 15:30:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 947A1F80103 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74181ADAA; Thu, 25 Mar 2021 14:30:03 +0000 (UTC) Date: Thu, 25 Mar 2021 15:30:03 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Subject: Re: [PATCH v2 2/2] ALSA: usb-audio: Check connector value on resume In-Reply-To: References: <20210325121250.133009-1-kai.heng.feng@canonical.com> <20210325121250.133009-2-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "moderated list:SOUND" , Lars-Peter Clausen , Pavel Skripkin , Chris Chiu , Takashi Iwai , Mark Brown , Joe Perches , Tom Yan , open list X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 25 Mar 2021 15:24:42 +0100, Kai-Heng Feng wrote: > > On Thu, Mar 25, 2021 at 9:55 PM Kai-Heng Feng > wrote: > > > > On Thu, Mar 25, 2021 at 9:41 PM Takashi Iwai wrote: > > > > > > On Thu, 25 Mar 2021 13:12:48 +0100, > > > Kai-Heng Feng wrote: > > > > > > > > Rear Mic on Lenovo P620 cannot record after S3, despite that there's no > > > > error and the other two functions of the USB audio, Line In and Line > > > > Out, work just fine. > > > > > > > > The mic starts to work again after running userspace app like "alsactl > > > > store". Following the lead, the evidence shows that as soon as connector > > > > status is queried, the mic can work again. > > > > > > > > So also check connector value on resume to "wake up" the USB audio to > > > > make it functional. > > > > > > > > This can be device specific, however I think this generic approach may > > > > benefit more than one device. > > > > > > > > While at it, also remove reset-resume path to consolidate mixer resume > > > > path. > > > > > > > > Signed-off-by: Kai-Heng Feng > > > > --- > > > > v2: > > > > - Remove reset-resume. > > > > - Fold the connector checking to the mixer resume callback. > > > > > > That's not what I meant exactly... I meant to put both into the > > > single resume callback, but handle each part conditionally depending > > > on reset_resume argument. > > > > OK, I get what you mean now. > > > > > > > > But this turned out to need more changes in mixer_quirks.c > > > unnecessarily. Maybe adding the two resume functions is a better > > > approach in the end, but not for the specific connection thing but > > > generically both resume and reset_resume callbacks. Something like > > > below. > > > > This approach looks good. Let me send another one. > > Actually, it works really well and I don't I think I should send the > code you wrote. > Is it possible to push your version with my commit log, and with my tested tag? > > Tested-by: Kai-Heng Feng Heh, I'm too lazy to write up the whole commit. Could you just fold into yours and submit a v3 series? I don't mind who is credited as the author, just put me as Suggested-by or such, if any. thanks, Takashi