From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C63C433FF for ; Fri, 9 Aug 2019 12:55:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93FE020B7C for ; Fri, 9 Aug 2019 12:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406879AbfHIMzl (ORCPT ); Fri, 9 Aug 2019 08:55:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:44474 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726232AbfHIMzl (ORCPT ); Fri, 9 Aug 2019 08:55:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1A087AC68; Fri, 9 Aug 2019 12:55:40 +0000 (UTC) Date: Fri, 09 Aug 2019 14:55:40 +0200 Message-ID: From: Takashi Iwai To: Cc: YueHaibing , , , , , Takashi Iwai , , Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h In-Reply-To: References: <20190809095550.71040-1-yuehaibing@huawei.com> <20190809110100.71236-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Aug 2019 14:53:55 +0200, Takashi Iwai wrote: > > On Fri, 09 Aug 2019 13:01:00 +0200, > YueHaibing wrote: > > > > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails: > > > > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init: > > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function > > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration] > > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > > > > Reported-by: Hulk Robot > > Suggested-by: Takashi Iwai > > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly") > ^ > Use " consistently for both opening and closing quotes. > > > Signed-off-by: YueHaibing > > Reviewed-by: Takashi Iwai Actually I'm going to take this again on top of topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to pull onto yours again. Sorry for the mess! Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h Date: Fri, 09 Aug 2019 14:55:40 +0200 Message-ID: References: <20190809095550.71040-1-yuehaibing@huawei.com> <20190809110100.71236-1-yuehaibing@huawei.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: broonie@kernel.org Cc: YueHaibing , lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com, yang.jie@linux.intel.com, perex@perex.cz, Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 09 Aug 2019 14:53:55 +0200, Takashi Iwai wrote: > > On Fri, 09 Aug 2019 13:01:00 +0200, > YueHaibing wrote: > > > > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails: > > > > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init: > > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function > > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration] > > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > > > > Reported-by: Hulk Robot > > Suggested-by: Takashi Iwai > > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly") > ^ > Use " consistently for both opening and closing quotes. > > > Signed-off-by: YueHaibing > > Reviewed-by: Takashi Iwai Actually I'm going to take this again on top of topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to pull onto yours again. Sorry for the mess! Takashi