All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Mohan Kumar <mkumard@nvidia.com>,
	pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ALSA: hda/hdmi: fix warning about PCM count when used with SOF
Date: Fri, 15 Apr 2022 09:21:42 +0200	[thread overview]
Message-ID: <s5h8rs64xrt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220414150516.3638283-1-kai.vehmanen@linux.intel.com>

On Thu, 14 Apr 2022 17:05:16 +0200,
Kai Vehmanen wrote:
> 
> With commit 13046370c4d1 ("ALSA: hda/hdmi: let new platforms assign the
> pcm slot dynamically"), old behaviour to consider the HDA pin number,
> when choosing PCM to assign, was dropped.
> 
> Build on this change and limit the number of PCMs created to number of
> converters (= maximum number of concurrent display/receivers) when
> "mst_no_extra_pcms" and "dyn_pcm_no_legacy" quirks are both set.
> 
> Fix the check in hdmi_find_pcm_slot() to ensure only spec->pcm_used
> entries are considered in the search. Elsewhere in the driver
> spec->pcm_used is already checked properly.
> 
> Doing this avoids following warning at SOF driver probe for multiple
> machine drivers:
> 
> [  112.425297] sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no
> PCM in topology for HDMI converter 4
> [  112.425298] sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no
> PCM in topology for HDMI converter 5
> [  112.425299] sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no
> PCM in topology for HDMI converter 6
> 
> BugLink: https://github.com/thesofproject/linux/issues/2573
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Thanks, applied now.


Takashi

      reply	other threads:[~2022-04-15  7:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 15:05 [PATCH] ALSA: hda/hdmi: fix warning about PCM count when used with SOF Kai Vehmanen
2022-04-15  7:21 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h8rs64xrt.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=mkumard@nvidia.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.