From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8036C433EF for ; Mon, 18 Jun 2018 10:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97AED208A6 for ; Mon, 18 Jun 2018 10:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97AED208A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934155AbeFRKj7 (ORCPT ); Mon, 18 Jun 2018 06:39:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:51477 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933382AbeFRKj6 (ORCPT ); Mon, 18 Jun 2018 06:39:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 99650AFA3; Mon, 18 Jun 2018 10:39:56 +0000 (UTC) Date: Mon, 18 Jun 2018 12:39:53 +0200 Message-ID: From: Takashi Iwai To: "Roman Sommer" Cc: , "Kees Cook" , "Daniel Graefe" , "Bhumika Goyal" , =?UTF-8?B?IkZhYmnDoW4gSW5vc3Ryb3phIg==?= , , "Thomas Gleixner" , "Greg Kroah-Hartman" , "Kate Stewart" , "Philippe Ombredanne" , "Jaroslav Kysela" , "Takashi Sakamoto" , =?UTF-8?B?IkhhbnMgUC4gTcO2?= =?UTF-8?B?bGxlciBFYm5lciI=?= , Subject: Re: [PATCH 0/3] sound/usb/line6: fix some styling issues In-Reply-To: <1529317779-15908-1-git-send-email-roman.sommer@fau.de> References: <1529317779-15908-1-git-send-email-roman.sommer@fau.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jun 2018 12:29:36 +0200, Roman Sommer wrote: > > CC: Jaroslav Kysela > CC: Takashi Iwai > CC: Takashi Sakamoto > CC: "Hans P. Möller Ebner" > CC: Kees Cook > CC: Kate Stewart > CC: Thomas Gleixner > CC: "Fabián Inostroza" > CC: Bhumika Goyal > CC: Philippe Ombredanne > CC: Greg Kroah-Hartman > CC: alsa-devel@alsa-project.org > CC: linux-kernel@vger.kernel.org > > > This patchseries addresses some styling issues in sound/usb/line6 found by > checkpatch. Are you working further on this driver to fix any real bugs (or implements something new), or it's an action "just because checkpatch tells"? I'd take such cleanup patches only for the former case. thanks, Takashi > > Roman Sommer (3): > sound/line6: checkpatch: fix block comment style > sound/line6: unsigned -> unsigned int > sound/line6: add newline after declarations > > sound/usb/line6/capture.c | 20 ++++----- > sound/usb/line6/driver.c | 110 ++++++++++++++++++++++----------------------- > sound/usb/line6/driver.h | 33 +++++++------- > sound/usb/line6/midi.c | 24 +++++----- > sound/usb/line6/midibuf.c | 6 +-- > sound/usb/line6/pcm.c | 26 +++++------ > sound/usb/line6/pcm.h | 74 +++++++++++++++--------------- > sound/usb/line6/playback.c | 36 ++++++++------- > sound/usb/line6/pod.c | 60 ++++++++++++------------- > sound/usb/line6/podhd.c | 8 ++-- > sound/usb/line6/toneport.c | 30 ++++++------- > sound/usb/line6/variax.c | 40 ++++++++--------- > 12 files changed, 235 insertions(+), 232 deletions(-) > > -- > 2.7.4 > >