From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbaBNGhq (ORCPT ); Fri, 14 Feb 2014 01:37:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49337 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbaBNGho (ORCPT ); Fri, 14 Feb 2014 01:37:44 -0500 Date: Fri, 14 Feb 2014 07:37:42 +0100 Message-ID: From: Takashi Iwai To: rauchwolke@gmx.net Cc: Matthew Garrett , "david.henningsson@canonical.com" , "ibm-acpi-devel@lists.sourceforge.net" , "platform-driver-x86@vger.kernel.org" , "ibm-acpi@hmh.eng.br" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume In-Reply-To: <0MGWR2-1W0rTh1wUC-00DE8E@mail.gmx.com> References: <1392219165-20888-1-git-send-email-tiwai@suse.de> <1392237456.1201.2.camel@x230> <0MGWR2-1W0rTh1wUC-00DE8E@mail.gmx.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 13 Feb 2014 19:02:46 +0100, rauchwolke@gmx.net wrote: > > Hi, > > this patch doesn't work. The sound is now muted after the resume (light is on). > But the userspace knows nothing about it. (kmix shows the volume as umuted) OK, scratch the last patch. I thought the mute LED is also a part of thinkpad_acpi's leds_class, but it's not. So, my initial patch is a correct fix in the end. Matthew, could you take it please? thanks, Takashi > > Peter > > > On Thu, 13 Feb 2014 09:35:30 +0100 > Takashi Iwai wrote: > > > At Wed, 12 Feb 2014 20:37:36 +0000, > > Matthew Garrett wrote: > > > > > > On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > > > > The mute LED states have to be restored after resume. > > > > > > Oh, never mind, we're not doing this through the LED class, are we? > > > > Good point. It seems that leds_class has pm_ops but it's enabled only > > when a flag is set. > > > > I added the original bug reporter to Cc. (Don't know the name, > > Bugzilla shows only the email address.) > > Could you check the patch below works instead of the previous fix? > > > > > > Takashi > > > > --- > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > > index defb6afc1409..16edf75d9c00 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight = { > > .name = "tpacpi::thinklight", > > .brightness_set = &light_sysfs_set, > > .brightness_get = &light_sysfs_get, > > + .flags = LED_CORE_SUSPENDRESUME, > > } > > }; > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume Date: Fri, 14 Feb 2014 07:37:42 +0100 Message-ID: References: <1392219165-20888-1-git-send-email-tiwai@suse.de> <1392237456.1201.2.camel@x230> <0MGWR2-1W0rTh1wUC-00DE8E@mail.gmx.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from cantor2.suse.de ([195.135.220.15]:49337 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbaBNGho (ORCPT ); Fri, 14 Feb 2014 01:37:44 -0500 In-Reply-To: <0MGWR2-1W0rTh1wUC-00DE8E@mail.gmx.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: rauchwolke@gmx.net Cc: Matthew Garrett , "david.henningsson@canonical.com" , "ibm-acpi-devel@lists.sourceforge.net" , "platform-driver-x86@vger.kernel.org" , "ibm-acpi@hmh.eng.br" , "linux-kernel@vger.kernel.org" At Thu, 13 Feb 2014 19:02:46 +0100, rauchwolke@gmx.net wrote: > > Hi, > > this patch doesn't work. The sound is now muted after the resume (light is on). > But the userspace knows nothing about it. (kmix shows the volume as umuted) OK, scratch the last patch. I thought the mute LED is also a part of thinkpad_acpi's leds_class, but it's not. So, my initial patch is a correct fix in the end. Matthew, could you take it please? thanks, Takashi > > Peter > > > On Thu, 13 Feb 2014 09:35:30 +0100 > Takashi Iwai wrote: > > > At Wed, 12 Feb 2014 20:37:36 +0000, > > Matthew Garrett wrote: > > > > > > On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote: > > > > The mute LED states have to be restored after resume. > > > > > > Oh, never mind, we're not doing this through the LED class, are we? > > > > Good point. It seems that leds_class has pm_ops but it's enabled only > > when a flag is set. > > > > I added the original bug reporter to Cc. (Don't know the name, > > Bugzilla shows only the email address.) > > Could you check the patch below works instead of the previous fix? > > > > > > Takashi > > > > --- > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > > index defb6afc1409..16edf75d9c00 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight = { > > .name = "tpacpi::thinklight", > > .brightness_set = &light_sysfs_set, > > .brightness_get = &light_sysfs_get, > > + .flags = LED_CORE_SUSPENDRESUME, > > } > > }; > > >