Re: [PATCH] ALSA: pcm: Mostly constify constraints

From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: pcm: Mostly constify constraints
Date: Thu, 05 Jul 2012 12:41:05 +0200	[thread overview]
Message-ID: <s5h8veylcce.wl%tiwai@suse.de> (raw)
In-Reply-To: <20120705103527.GM4111@opensource.wolfsonmicro.com>

At Thu, 5 Jul 2012 11:35:28 +0100,
Mark Brown wrote:
> 
> On Thu, Jul 05, 2012 at 11:55:36AM +0200, Takashi Iwai wrote:
> 
> > The rule->private pointer isn't designed to be always const.  The data
> > purely depends on each rule function, thus whether it can be const or
> > not also depends on the rule, too.  For simple rules like list take
> > indeed the constant list.  But more complex rules may take a struct
> > containing variables changed on the fly (e.g. the max rate set by
> > user via control API).
> 
> Well, it's mostly const - it's const unless the rule itself starts
> fiddling with stuff which I'd have expected to be the exception rather
> than the rule.

Well, the only rule is that rule (function) rules the meaning of the
private pointer :)


Takashi