From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Add a reset interface Date: Mon, 24 Jan 2011 17:28:24 +0100 Message-ID: References: <1295884531-600-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 716BD9E801 for ; Mon, 24 Jan 2011 08:28:25 -0800 (PST) In-Reply-To: <1295884531-600-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: mat@mshopf.de, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org At Mon, 24 Jan 2011 15:55:27 +0000, Chris Wilson wrote: > > For i915 there is a need to invalidate some cached state after resuming or > reseting the GPU. This is not quite the same as simply restoring saved > state (i.e. the standard suspend resume method), so do not seem to merit > reusing the save|restore vfuncs. Instead I propose a > > drm_mode_config_reset(struct drm_device *); > > routine to iterate over all the attached CRTCs, encoders and connectors > and call any supplied reset vfunc. > > This is required to fix some modesetting regressions across resume in > 2.6.38: > https://bugzilla.kernel.org/show_bug.cgi?id=26952 > https://bugzilla.kernel.org/show_bug.cgi?id=27272 I quickly tried these patches. After adding the missing EXPORT_SYMBOL, it seems working fine. Tested on a SNB laptop and a PineView laptop. Put my tag to all patches: Tested-by: Takashi Iwai Thanks! Takashi