From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E04C07E9B for ; Tue, 20 Jul 2021 15:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7718610F7 for ; Tue, 20 Jul 2021 15:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240647AbhGTPHC (ORCPT ); Tue, 20 Jul 2021 11:07:02 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:57420 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242160AbhGTO7s (ORCPT ); Tue, 20 Jul 2021 10:59:48 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8978722453; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=A5Wq15YU8vSgD4IWRe1+oClfodgFa8siOLcT4FZxf0P/y/jS+Y/f2XmA3eWxh54vKA4TT0 aCeZZU4KOk1M/N1r9XgdJDEmg0cpw66asaLBUsx2kCiNT1hZlznVIBe4Ld4RUrGNcjZmyP ef1X4RLiYNIETZn8IbZmqf7af+23Qow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=7qMtDYzURtCrQN9JWRU7bf5pfv1Rqs7Bhf9scnCsrxOjj8p4biEa2zly7kctAHPcO0ZiAs jLsJ8gZv7nW1PMDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 71938A3B98; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) Date: Tue, 20 Jul 2021 17:40:22 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block In-Reply-To: <20210720153741.73230-1-colin.king@canonical.com> References: <20210720153741.73230-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021 17:37:41 +0200, Colin King wrote: > > From: Colin Ian King > > Currently the { } braces are missing around an if block causing subsequent > code after the return to become unreachable. Fix this by adding the > missing { }. > > Addresses-Coverity: ("Structurally dead code") > Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs") > Signed-off-by: Colin Ian King Thanks, applied. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F20C07E95 for ; Tue, 20 Jul 2021 15:41:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6905E61029 for ; Tue, 20 Jul 2021 15:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6905E61029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D1CB01669; Tue, 20 Jul 2021 17:40:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D1CB01669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626795680; bh=7ArFbZ7pWm0b0RKnzWa672by4uqOWrNYwQZeUw9sisA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VO22Dmi5JxB96xRuMnDHFpR3I+7Goea5ZmadvFbAyBctesKiS+6ESvqVUhP+7gJa9 T4w+h9/my+dVAEZ/RRTgdjtUjI7fcfjDyjU3C54Ffl9WimNxf8pBkOas+280+CYmWQ ostaHM7mTyErTV9uM1iFzHOdXmqz8DjnoemIgzBY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 79D0CF80169; Tue, 20 Jul 2021 17:40:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1B368F8020D; Tue, 20 Jul 2021 17:40:29 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C76E6F800DA for ; Tue, 20 Jul 2021 17:40:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C76E6F800DA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="A5Wq15YU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="7qMtDYzU" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8978722453; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=A5Wq15YU8vSgD4IWRe1+oClfodgFa8siOLcT4FZxf0P/y/jS+Y/f2XmA3eWxh54vKA4TT0 aCeZZU4KOk1M/N1r9XgdJDEmg0cpw66asaLBUsx2kCiNT1hZlznVIBe4Ld4RUrGNcjZmyP ef1X4RLiYNIETZn8IbZmqf7af+23Qow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=7qMtDYzURtCrQN9JWRU7bf5pfv1Rqs7Bhf9scnCsrxOjj8p4biEa2zly7kctAHPcO0ZiAs jLsJ8gZv7nW1PMDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 71938A3B98; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) Date: Tue, 20 Jul 2021 17:40:22 +0200 Message-ID: From: Takashi Iwai To: Colin King Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block In-Reply-To: <20210720153741.73230-1-colin.king@canonical.com> References: <20210720153741.73230-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 20 Jul 2021 17:37:41 +0200, Colin King wrote: > > From: Colin Ian King > > Currently the { } braces are missing around an if block causing subsequent > code after the return to become unreachable. Fix this by adding the > missing { }. > > Addresses-Coverity: ("Structurally dead code") > Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs") > Signed-off-by: Colin Ian King Thanks, applied. Takashi