From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BF1C433E7 for ; Mon, 12 Oct 2020 09:10:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6C712076D for ; Mon, 12 Oct 2020 09:10:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ot0O2BVU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C712076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9203E166F; Mon, 12 Oct 2020 11:09:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9203E166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602493800; bh=7fblKHRxM4UnRtgOFex9MANsOtHxNgWWXggtiG2AkHA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ot0O2BVUANBHqQx6NEXjKtnXSdwrWDwd1f1R88nz+i63DyZwiP4eG4mdfrMzg872P qspQIQzkFf1ToravZdTnXpubQEV8kjaSJvlKok3MdQzmrS/ecx7sNgYeSKWg7DOnr2 P2qGewSiWksTkC/qTu1dFWaL2Ir81vPX0bFm8cwE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 29892F8020D; Mon, 12 Oct 2020 11:09:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6280DF80217; Mon, 12 Oct 2020 11:09:08 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CE151F80141 for ; Mon, 12 Oct 2020 11:09:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CE151F80141 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A58C6AE9A; Mon, 12 Oct 2020 09:09:04 +0000 (UTC) Date: Mon, 12 Oct 2020 11:09:04 +0200 Message-ID: From: Takashi Iwai To: Hans de Goede Subject: Re: [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components In-Reply-To: References: <20201006064907.16277-1-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Cezary Rojewski , krzysztof.hejmowski@intel.com, filip.kaczmarski@intel.com, harshapriya.n@intel.com, lgirdwood@gmail.com, ppapierkowski@habana.ai, marcin.barlik@intel.com, zwisler@google.com, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, filip.proborszcz@intel.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, michal.wasko@intel.com, tiwai@suse.com, andriy.shevchenko@linux.intel.com, cujomalainey@chromium.org, vamshi.krishna.gopal@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 12 Oct 2020 10:26:17 +0200, Hans de Goede wrote: > > FWIW (since that this is already merged) I'm fine with removing the > quite old Bay Trail support from common/sst-acpi.c, at least Fedora > has been using the medium-old (with SOF being the new thing) > CONFIG_SND_SST_IPC_ACPI support for Bay Trail audio support for > quite some time now. The same for openSUSE. Since CONFIG_SND_SOC_INTEL_BAYTRAIL is exclusive against SOF and other modern codes, I guess it's quite unlikely that any recent distros enable it. > This is not just about Bay Trail And Cherry Trail devices though, > this series also makes changes impacting Haswell and Broadwell devices. > > The commit removing this support claims that at least for Haswell the > new sound/soc/intel/catpt replaces it, but I do not see that code in > 5.9, so that means that in one cycle we are both introducing the > replacement and dropping the old code ? I'm not sure if that is such > a great idea, what is the fallback plan if testing does find significant > issues with the new catpt code ? I find the action a bit too rushing, too. OTOH, the old code wasn't well maintained, honestly speaking. So, from another perspective, switching to a new code can be seen as a better chance to fix any bugs. Of course, we could keep two stuff parallel, but it's rather confusing. And, the HSW/BDW devices that need SST are quite rare and old, so the impact is limited, I guess. In anyway, let's cross fingers, and feed back to Cezary ASAP when we get a regression. thanks, Takashi