From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520CDC47247 for ; Thu, 30 Apr 2020 17:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 381CF20787 for ; Thu, 30 Apr 2020 17:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbgD3RWq (ORCPT ); Thu, 30 Apr 2020 13:22:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:58002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbgD3RWq (ORCPT ); Thu, 30 Apr 2020 13:22:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 25C96AC64; Thu, 30 Apr 2020 17:22:44 +0000 (UTC) Date: Thu, 30 Apr 2020 19:22:44 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Tomas Espeleta , Thomas Hebb , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , "moderated list:SOUND" , open list Subject: Re: [PATCH v2 3/3] ALSA: hda/realtek - Add LED class support for micmute LED In-Reply-To: <20200430135209.14703-1-kai.heng.feng@canonical.com> References: <20200430083255.5093-3-kai.heng.feng@canonical.com> <20200430135209.14703-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Apr 2020 15:52:07 +0200, Kai-Heng Feng wrote: > > Currently DMIC controls micmute LED via "audio mute LED trigger". > > However, unlike Dell and Lenovo platforms, HP platforms don't provide a > way to control micmute LED via ACPI, it's controlled by HDA codec > instead. > > So let's register an LED class for micmute so other subsystems like DMIC > can facilitate the codec-controlled LED. > > Signed-off-by: Kai-Heng Feng > --- > v2: > - Only compile the code when CONFIG_LEDS_TRIGGER_AUDIO is reachable. Applied to for-next branch. Thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73EB2C47247 for ; Thu, 30 Apr 2020 17:24:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F10C02082E for ; Thu, 30 Apr 2020 17:24:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Q8UYf5Da" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F10C02082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4B67A1694; Thu, 30 Apr 2020 19:23:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4B67A1694 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588267456; bh=ZJOZY/9i6hT7JP1gKkaf4LtZ6CFAvovibTfQsVczr3I=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Q8UYf5DaP4BibUdtNz0Tcs//+aflL8lJZIdCPW+HGcAWtQ546FjM/Fin79RxrX6Xi WaOtlvvNfBA/6tyRbSwSMnaRhV08BRw1f4SrJz4rl8uK3Vq25RsS4Axshq9xaX9tKz bin2LA3yOBuVufH7mLTSaintAP/3H8ypMvkpZ/0E= Received: from vmi242170.contaboserver.net (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6871DF8021C; Thu, 30 Apr 2020 19:22:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B0EAF80136; Thu, 30 Apr 2020 19:22:51 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5A50EF801EB for ; Thu, 30 Apr 2020 19:22:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5A50EF801EB X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 25C96AC64; Thu, 30 Apr 2020 17:22:44 +0000 (UTC) Date: Thu, 30 Apr 2020 19:22:44 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Subject: Re: [PATCH v2 3/3] ALSA: hda/realtek - Add LED class support for micmute LED In-Reply-To: <20200430135209.14703-1-kai.heng.feng@canonical.com> References: <20200430083255.5093-3-kai.heng.feng@canonical.com> <20200430135209.14703-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "moderated list:SOUND" , Kailang Yang , Tomas Espeleta , open list , tiwai@suse.com, Hui Wang , Thomas Hebb , Jian-Hong Pan , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 30 Apr 2020 15:52:07 +0200, Kai-Heng Feng wrote: > > Currently DMIC controls micmute LED via "audio mute LED trigger". > > However, unlike Dell and Lenovo platforms, HP platforms don't provide a > way to control micmute LED via ACPI, it's controlled by HDA codec > instead. > > So let's register an LED class for micmute so other subsystems like DMIC > can facilitate the codec-controlled LED. > > Signed-off-by: Kai-Heng Feng > --- > v2: > - Only compile the code when CONFIG_LEDS_TRIGGER_AUDIO is reachable. Applied to for-next branch. Thanks. Takashi