From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84503C7619F for ; Mon, 17 Feb 2020 09:18:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 131C02070B for ; Mon, 17 Feb 2020 09:18:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RemSsc9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 131C02070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 59FC5826; Mon, 17 Feb 2020 10:17:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 59FC5826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581931103; bh=MH2dIAeDNl4VW3wx8daFt81nVoOKuEXWeQKkX9pYLrE=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RemSsc9Y/EuBYqXV4i+rUVZvW75PZ4z55nkHgvB/bhP6YQBTLPoayhtZYi97e0OId U6+wJG9vY2XrpkSWymXu/fBc1pUFoVOgH06uRddPACZoYdSwQnrfa/i/1E3aUZ4lcP /uQFvztNtBvNGUZfm4VssH1fc1jHbklpjt1siQD8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DF088F800B6; Mon, 17 Feb 2020 10:17:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 85398F80172; Mon, 17 Feb 2020 10:17:31 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 53CCEF800B6 for ; Mon, 17 Feb 2020 10:17:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 53CCEF800B6 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A2C9DBE45; Mon, 17 Feb 2020 09:17:28 +0000 (UTC) Date: Mon, 17 Feb 2020 10:17:28 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: References: <20200216203516.10869-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, Mark Brown , Pierre-Louis Bossart , Ranjani Sridharan Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 17 Feb 2020 10:11:59 +0100, Kai Vehmanen wrote: > > Hi Takashi, > > On Sun, 16 Feb 2020, Takashi Iwai wrote: > > > When the driver is configured with CONFIG_SND_SOC_SOF_HDA, the SOF > > driver tries to bind with i915 audio component. But there is also a > > system without Intel graphics. On such a system, snd_hdac_i915_init() > > returns -ENODEV error and it leads to the whole probe error of SOF > > driver. > > d'oh -- I was a bit too late with this. I've been working on the bug for a > while and a work in progress patch has been available in the bug for a > couple of weeks: > https://github.com/thesofproject/linux/issues/1658 > https://github.com/thesofproject/linux/pull/1731 > > .. there have been multiple issues, so that the patchset has taken > multiple rounds, but it's very close now. Probably should have added > something in the other bugtrackers as well to avoid duplicated efforts. > > With my patchset, if i915 is not present or the init fails, only the idisp > codec is dropped and the probe continues for other codecs. > > Your patch will partly conflict with mine as I rely on i915_init to > report failure in this case. Ok if we wait until my patch gets in? Sure, mine is just a quick fix. If there is already a work on it, let's take it instead. But, this HP machine still seems broken even after ignoring i915, so we'd need more work in anyway? thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel