From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E0D7C31E40 for ; Fri, 9 Aug 2019 12:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A37C21883 for ; Fri, 9 Aug 2019 12:53:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406903AbfHIMx5 (ORCPT ); Fri, 9 Aug 2019 08:53:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:43240 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726091AbfHIMx5 (ORCPT ); Fri, 9 Aug 2019 08:53:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 515A7AEA1; Fri, 9 Aug 2019 12:53:56 +0000 (UTC) Date: Fri, 09 Aug 2019 14:53:55 +0200 Message-ID: From: Takashi Iwai To: YueHaibing Cc: , , , , , Takashi Iwai , , Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h In-Reply-To: <20190809110100.71236-1-yuehaibing@huawei.com> References: <20190809095550.71040-1-yuehaibing@huawei.com> <20190809110100.71236-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Aug 2019 13:01:00 +0200, YueHaibing wrote: > > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails: > > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init: > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration] > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > > Reported-by: Hulk Robot > Suggested-by: Takashi Iwai > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly") ^ Use " consistently for both opening and closing quotes. > Signed-off-by: YueHaibing Reviewed-by: Takashi Iwai thanks, Takashi > --- > v2: remove unused include from hda.c > --- > sound/soc/sof/intel/hda-bus.c | 1 + > sound/soc/sof/intel/hda.c | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/sof/intel/hda-bus.c b/sound/soc/sof/intel/hda-bus.c > index 0caec3a..1d2babd 100644 > --- a/sound/soc/sof/intel/hda-bus.c > +++ b/sound/soc/sof/intel/hda-bus.c > @@ -13,6 +13,7 @@ > #include "hda.h" > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > +#include "../../codecs/hdac_hda.h" > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > #else > #define sof_hda_ext_ops NULL > diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c > index 368254b..ebf2777 100644 > --- a/sound/soc/sof/intel/hda.c > +++ b/sound/soc/sof/intel/hda.c > @@ -23,9 +23,6 @@ > #include > #include "../ops.h" > #include "hda.h" > -#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > -#include "../../codecs/hdac_hda.h" > -#endif > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) > #include > -- > 2.7.4 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h Date: Fri, 09 Aug 2019 14:53:55 +0200 Message-ID: References: <20190809095550.71040-1-yuehaibing@huawei.com> <20190809110100.71236-1-yuehaibing@huawei.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190809110100.71236-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: lgirdwood@gmail.com, broonie@kernel.org, pierre-louis.bossart@linux.intel.com, yang.jie@linux.intel.com, perex@perex.cz, Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 09 Aug 2019 13:01:00 +0200, YueHaibing wrote: > > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails: > > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init: > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function > snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration] > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > > Reported-by: Hulk Robot > Suggested-by: Takashi Iwai > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly") ^ Use " consistently for both opening and closing quotes. > Signed-off-by: YueHaibing Reviewed-by: Takashi Iwai thanks, Takashi > --- > v2: remove unused include from hda.c > --- > sound/soc/sof/intel/hda-bus.c | 1 + > sound/soc/sof/intel/hda.c | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/sof/intel/hda-bus.c b/sound/soc/sof/intel/hda-bus.c > index 0caec3a..1d2babd 100644 > --- a/sound/soc/sof/intel/hda-bus.c > +++ b/sound/soc/sof/intel/hda-bus.c > @@ -13,6 +13,7 @@ > #include "hda.h" > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > +#include "../../codecs/hdac_hda.h" > #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops() > #else > #define sof_hda_ext_ops NULL > diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c > index 368254b..ebf2777 100644 > --- a/sound/soc/sof/intel/hda.c > +++ b/sound/soc/sof/intel/hda.c > @@ -23,9 +23,6 @@ > #include > #include "../ops.h" > #include "hda.h" > -#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > -#include "../../codecs/hdac_hda.h" > -#endif > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) > #include > -- > 2.7.4 > > >