From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id A3280C433EF for ; Thu, 14 Jun 2018 16:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A465208DA for ; Thu, 14 Jun 2018 16:07:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A465208DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755285AbeFNQH1 (ORCPT ); Thu, 14 Jun 2018 12:07:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:41290 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755010AbeFNQH0 (ORCPT ); Thu, 14 Jun 2018 12:07:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C358FAD03; Thu, 14 Jun 2018 16:07:25 +0000 (UTC) Date: Thu, 14 Jun 2018 18:07:25 +0200 Message-ID: From: Takashi Iwai To: Jorge Sanjuan Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ruslan.bilovol@gmail.com Subject: Re: [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors. In-Reply-To: <20180614140558.28277-1-jorge.sanjuan@codethink.co.uk> References: <20180612143201.29988-1-jorge.sanjuan@codethink.co.uk> <20180614140558.28277-1-jorge.sanjuan@codethink.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jun 2018 16:05:54 +0200, Jorge Sanjuan wrote: > > Thanks for review! > > Here is what's new in this V2: > - Split the patchset into a more sensible series. > > This patchset adds support for the Insertion Control for BADD devices > (subset of UAC3). > > This control is only pressent in the HEADSET ADAPTER BADD profile. The USB > interrupt pipe shall be present for this profile so the status pipe > creation should also happen for BADD devices. > > Also, the bi-directional type codes have been defined so they can be used > as inferred values for the Input and Output terminals for this adapter > profile. > > Based on tag: next-20180612 > > Jorge Sanjuan (4): > ALSA: usb-audio: Add bi-directional terminal types. > ALSA: usb-audio: Change in connectors control creation interface > ALSA: usb-audio: UAC3. Add insertion control for BADD. > ALSA: usb-audio: Always create the interrupt pipe for the mixer Thanks, this looks nicer, each of changes is smaller and clearer. Although it's a bit too late for the merge window, this is a change that is fairly safe for the existing UAC1/UAC2, I merged it now. Oh, and the subjects were slightly fixed; no need of period at the tail in a subject line. Takashi