From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [RFC PATCH] Inverted internal mic
Date: Fri, 22 Jun 2012 17:37:31 +0200
Message-ID: <s5ha9zvbbno.wl%tiwai@suse.de>
References: <4F4C9714.1080307@canonical.com> <s5haa43ux7u.wl%tiwai@suse.de>
	<4F4CA438.90103@canonical.com> <s5hvcmrp7ji.wl%tiwai@suse.de>
	<4F4CD1AF.2050409@canonical.com> <s5hboojozx7.wl%tiwai@suse.de>
	<4F4CE264.7040008@canonical.com>
	<loom.20120619T050139-760@post.gmane.org>
	<4FE02D8B.7050201@canonical.com> <s5htxy6f6tt.wl%tiwai@suse.de>
	<4FE275AF.4080004@canonical.com> <s5hhau4esiu.wl%tiwai@suse.de>
	<4FE31BEC.20708@canonical.com> <s5hbokcerax.wl%tiwai@suse.de>
	<4FE32E74.1040902@canonical.com> <s5h62aj4rov.wl%tiwai@suse.de>
	<4FE44D1F.1060903@canonical.com> <s5h1ul7d31x.wl%tiwai@suse.de>
	<s5hsjdnbjka.wl%tiwai@suse.de> <4FE48EF7.6060101@canonical.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id E10F6103FAE
	for <alsa-devel@alsa-project.org>;
	Fri, 22 Jun 2012 17:37:34 +0200 (CEST)
In-Reply-To: <4FE48EF7.6060101@canonical.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, Eliot Blennerhassett <eliot@blennerhassett.gen.nz>
List-Id: alsa-devel@alsa-project.org

At Fri, 22 Jun 2012 17:27:51 +0200,
David Henningsson wrote:
> 
> On 06/22/2012 02:46 PM, Takashi Iwai wrote:
> >   /*
> > + * Inverted digital-mic handling
> > + *
> > + * First off, it's a bit tricky.  The "Inverted Internal Mic Capture Switch"
> > + * gives the additional mute only to the right channel of the digital mic
> > + * capture stream.  This is a workaround for avoiding the almost silence
> > + * by summing the stereo stereo stream from some (known to be ForteMedia)
> 
> Stereo stereo? It's "stereo" in stereo! :-)

Yeah, quad channels.  Fixed now.

> > + * digital mic unit.
> > + *
> > + * The logic is to call alc_inv_dmic_sync() after each action (possibly)
> > + * modifying ADC amp.  When the mute flag is set, it mutes the R-channel
> > + * without caching so that the cache can still keep the original value.
> > + * The cached value is then restored when the flag is set off or any other
> > + * than d-mic is used as the current input source.
> 
> Ok, I get it now.
> 
> There is a slight drawback with this (IMO a bit hacky) patch, and that 
> is that you can get a short signal spike on the right channel when you 
> turn "Capture Switch" on while "Inverted Capture" is off. Hopefully it 
> is not a practical problem.

Right, I fully admit it's hacky :)

A good thing by this is, however, that it doesn't touch other parts
too intrusively but just wraps over it.

> Thanks for looking at this long-standing problem :-)

I'm going to commit it once after hearing the test with a real machine
from Eliot.

Thanks for your review!


Takashi