All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	903853@bugs.launchpad.net
Subject: Re: [RFC PATCH] Inverted internal mic
Date: Tue, 28 Feb 2012 10:24:37 +0100	[thread overview]
Message-ID: <s5haa43ux7u.wl%tiwai@suse.de> (raw)
In-Reply-To: <4F4C9714.1080307@canonical.com>

At Tue, 28 Feb 2012 09:57:56 +0100,
David Henningsson wrote:
> 
> Hi,
> 
> One of the more common problems on laptop machines, is that the internal 
> mic provides a stereo signal but with one channel phase inverted, or 
> differential output.
> 
> This means problems for applications recording two channels but later 
> merging them into one, leaving them with zero or near-zero output.
> 
> There are various ways we can work around this in both the kernel, 
> alsa-lib and PulseAudio layers. It's a matter of picking the right one. 
> I'm leaning towards trying to fix it in the kernel's codec drivers, because
> 1) we already have quirking infrastructure there
> 2) we already have some working quirks already in that layer
> 3) it would benefit other sound applications that use ALSA directly.
> 
> The downside to that is really that we're silencing out one channel for
> everyone, leading to no application being able to use both channels, 
> even if they would implement some kind of 
> "auto-detect-and-reverse-one-channel" functionality.
> 
> For the most part, this has been some Acer Aspire machines running 
> Realtek ALC268 / ALC269 / ALC271X / ALC272X, and for two of these we 
> have proc coefs we can set, but for the other two these proc coefs, if 
> they exist, are unknown to us.
> 
> Recently I came across a Conexant as well, and I decided to write a 
> patch for it, that would take the approach that the internal mic is 
> forced mono on the kcontrol, and make sure the right channel is always 
> muted. The patch is verified by the reporter to fix this problem. It 
> could use some perfection though - it would make sense to to the same to 
> the internal mic boost as well, and the strcmp('Internal Mic') call 
> could maybe be turned into something more elegant. But before going 
> ahead with that, I'd like to hear your opinion on the matter, if you 
> agree that this is a good approach to the problem?

The remaining problem in the patch is that the signal is recorded only
on left when you record in stereo.  I guess the reporter tested only a
program like Skype, which uses only a mono stream.

If this behavior, only one channel in a stereo stream, is acceptable,
it's a reasonable fix, I think.


Takashi

  reply	other threads:[~2012-02-28  9:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28  8:57 [RFC PATCH] Inverted internal mic David Henningsson
2012-02-28  9:24 ` Takashi Iwai [this message]
2012-02-28  9:54   ` David Henningsson
2012-02-28 10:38     ` Takashi Iwai
2012-02-28 13:07       ` David Henningsson
2012-02-28 13:22         ` Takashi Iwai
2012-02-28 14:19           ` David Henningsson
2012-02-28 15:20             ` Takashi Iwai
2012-02-28 18:11               ` David Henningsson
2012-02-28 19:42                 ` Takashi Iwai
2012-02-29  9:21                   ` David Henningsson
2012-02-29  9:56                     ` Takashi Iwai
2012-02-29 10:45                       ` David Henningsson
2012-02-29 16:36                         ` Takashi Iwai
2012-06-19  3:07             ` Eliot Blennerhassett
2012-06-19  7:43               ` David Henningsson
2012-06-20 13:31                 ` Takashi Iwai
2012-06-21  1:15                   ` David Henningsson
2012-06-21 12:52                     ` Takashi Iwai
2012-06-21 13:04                       ` David Henningsson
2012-06-21 13:19                         ` Takashi Iwai
2012-06-21 14:23                           ` David Henningsson
2012-06-22  9:33                             ` Takashi Iwai
2012-06-22 10:46                               ` David Henningsson
2012-06-22 11:00                                 ` Takashi Iwai
2012-06-22 12:46                                   ` Takashi Iwai
2012-06-22 15:27                                     ` David Henningsson
2012-06-22 15:37                                       ` Takashi Iwai
2012-06-22 17:33                                         ` David Henningsson
2012-06-23  2:58                                           ` Eliot Blennerhassett
2012-06-23  8:40                                             ` Takashi Iwai
2012-06-23  8:39                                           ` Takashi Iwai
2012-06-25  8:04                                             ` David Henningsson
2012-06-25  8:18                                               ` Takashi Iwai
2012-06-20  8:02               ` Takashi Iwai
2012-06-20 10:54                 ` Eliot Blennerhassett
2012-02-29 11:02 ` Raymond Yau
2012-06-20 21:53 ` James Courtier-Dutton
2012-06-21  5:56   ` Takashi Iwai
2014-10-20 13:52 rodney byne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5haa43ux7u.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=903853@bugs.launchpad.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.